Commits on Feb 6, 2024

1. [MIPS] Use generic isBlockOnlyReachableByFallthrough …

   This should fix rust-lang/rust#108835
   
   FastISel may create a redundant BGTZ terminal which fallthroughes.
   ```
     BGTZ %2:gpr32, %bb.1, implicit-def $at
   
   bb.1.bb1:
   ; predecessors: %bb.0
   ```
   
   The `!I->isBarrier()` check in MipsAsmPrinter::isBlockOnlyReachableByFallthrough
   will incorrectly not print a label, leading to a `Undefined temporary symbol `
   error when we try assembling the output assembly file. See the updated
   `Fast-ISel/pr40325.ll` and rust-lang/rust#108835
   
   In addition, the `SwitchInst` condition is too conservative and prints
   many unneeded labels (see the updated tests).
   
   Just use the generic isBlockOnlyReachableByFallthrough, updated by
   commit 1995b9f for SPARC, which also
   handles MIPS.

   

   MaskRay committed Feb 6, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9ca9533
   • Browse repository at this point

   Copy the full SHA

   9ca9533 View commit details

   Browse the repository at this point in the history