Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflows] Fix libclc CI tests #80942

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[workflows] Fix libclc CI tests #80942

merged 1 commit into from
Feb 7, 2024

Conversation

tstellar
Copy link
Collaborator

@tstellar tstellar commented Feb 7, 2024

This was broken by 1a64260.

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 7, 2024

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

This was broken by 1a64260.


Full diff: https://github.com/llvm/llvm-project/pull/80942.diff

1 Files Affected:

  • (modified) .github/workflows/llvm-project-tests.yml (+7-3)
diff --git a/.github/workflows/llvm-project-tests.yml b/.github/workflows/llvm-project-tests.yml
index 3bc7bd4957fa6..68b4a68d1af98 100644
--- a/.github/workflows/llvm-project-tests.yml
+++ b/.github/workflows/llvm-project-tests.yml
@@ -104,14 +104,16 @@ jobs:
           # This should be a no-op for non-mac OSes
           PKG_CONFIG_PATH: /usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig//12
         shell: bash
+        id: build-llvm
         run: |
           if [ "${{ runner.os }}" == "Linux" ]; then
             builddir="/mnt/build/"
             sudo mkdir -p $builddir
             sudo chown `whoami`:`whoami` $builddir
           else
-            builddir=build
+            builddir="$(pwd)"/build
           fi
+          echo "llvm-builddir=$builddir" >> "$GITHUB_OUTPUT"
           cmake -G Ninja \
                 -B "$builddir" \
                 -S llvm \
@@ -126,9 +128,11 @@ jobs:
 
       - name: Build and Test libclc
         if: "!startsWith(matrix.os, 'windows') && contains(inputs.projects, 'libclc')"
+        env:
+          LLVM_BUILDDIR: ${{ steps.build-llvm.outputs.llvm-builddir }}
         run: |
           # Make sure all of LLVM libraries that llvm-config needs are built.
-          ninja -C build
-          cmake -G Ninja -S libclc -B libclc-build -DLLVM_DIR="$(pwd)"/build/lib/cmake/llvm -DLIBCLC_TARGETS_TO_BUILD="amdgcn--;amdgcn--amdhsa;r600--;nvptx--;nvptx64--;nvptx--nvidiacl;nvptx64--nvidiacl"
+          ninja -C "$LLVM_BUILDDIR"
+          cmake -G Ninja -S libclc -B libclc-build -DLLVM_DIR="$LLVM_BUILDDIR"/lib/cmake/llvm -DLIBCLC_TARGETS_TO_BUILD="amdgcn--;amdgcn--amdhsa;r600--;nvptx--;nvptx64--;nvptx--nvidiacl;nvptx64--nvidiacl"
           ninja -C libclc-build
           ninja -C libclc-build test

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we make some of the other workflows that depend on this file trigger when it gets changed so that we can catch regressions in future PRs?

@tstellar
Copy link
Collaborator Author

tstellar commented Feb 7, 2024

LGTM. Should we make some of the other workflows that depend on this file trigger when it gets changed so that we can catch regressions in future PRs?

Yes, I think that would be a good idea.

@tstellar tstellar merged commit ab92f62 into llvm:main Feb 7, 2024
7 of 8 checks passed
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 8, 2024
This was broken by 1a64260.

(cherry picked from commit ab92f62)
tstellar added a commit that referenced this pull request Feb 8, 2024
This was broken by 1a64260.

(cherry picked from commit ab92f62)
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
This was broken by 1a64260.

(cherry picked from commit ab92f62)
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
This was broken by 1a64260.

(cherry picked from commit ab92f62)
tstellar added a commit to tstellar/llvm-project that referenced this pull request Feb 14, 2024
This was broken by 1a64260.

(cherry picked from commit ab92f62)
@pointhex pointhex mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants