[NFC] clang-format utils/TableGen #80973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
backend:X86
backend:DirectX
llvm:SelectionDAG
|
@llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-llvm-selectiondag Author: Pierre van Houtryve (Pierre-vh) ChangesSplit from #80847 - there is quite a bit more reformatting going on here because this is a full reformating of every file. Patch is 691.81 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/80973.diff 61 Files Affected:
diff --git a/llvm/utils/TableGen/AsmMatcherEmitter.cpp b/llvm/utils/TableGen/AsmMatcherEmitter.cpp
index 011d96a48d61d..9065885618069 100644
--- a/llvm/utils/TableGen/AsmMatcherEmitter.cpp
+++ b/llvm/utils/TableGen/AsmMatcherEmitter.cpp
@@ -140,10 +140,11 @@ class AsmMatcherInfo;
// RegisterSets can be seen in the outputted AsmMatcher tables occasionally, and
// can even affect compiler output (at least seen in diagnostics produced when
// all matches fail). So we use a type that sorts them consistently.
-typedef std::set<Record*, LessRecordByID> RegisterSet;
+typedef std::set<Record *, LessRecordByID> RegisterSet;
class AsmMatcherEmitter {
RecordKeeper &Records;
+
public:
AsmMatcherEmitter(RecordKeeper &R) : Records(R) {}
@@ -166,7 +167,7 @@ struct ClassInfo {
/// The (first) user defined class, subsequent user defined classes are
/// UserClass0+1, and so on.
- UserClass0 = 1<<16
+ UserClass0 = 1 << 16
};
/// Kind - The class kind, which is either a predefined kind, or (UserClass0 +
@@ -176,7 +177,7 @@ struct ClassInfo {
/// SuperClasses - The super classes of this class. Note that for simplicities
/// sake user operands only record their immediate super class, while register
/// operands include all superclasses.
- std::vector<ClassInfo*> SuperClasses;
+ std::vector<ClassInfo *> SuperClasses;
/// Name - The full class name, suitable for use in an enum.
std::string Name;
@@ -204,10 +205,12 @@ struct ClassInfo {
/// For register classes: the records for all the registers in this class.
RegisterSet Registers;
- /// For custom match classes: the diagnostic kind for when the predicate fails.
+ /// For custom match classes: the diagnostic kind for when the predicate
+ /// fails.
std::string DiagnosticType;
- /// For custom match classes: the diagnostic string for when the predicate fails.
+ /// For custom match classes: the diagnostic string for when the predicate
+ /// fails.
std::string DiagnosticString;
/// Is this operand optional and not always required.
@@ -224,9 +227,7 @@ struct ClassInfo {
}
/// isUserClass() - Check if this is a user defined class.
- bool isUserClass() const {
- return Kind >= UserClass0;
- }
+ bool isUserClass() const { return Kind >= UserClass0; }
/// isRelatedTo - Check whether this class is "related" to \p RHS. Classes
/// are related if they are in the same class hierarchy.
@@ -244,8 +245,8 @@ struct ClassInfo {
RegisterSet Tmp;
std::insert_iterator<RegisterSet> II(Tmp, Tmp.begin());
std::set_intersection(Registers.begin(), Registers.end(),
- RHS.Registers.begin(), RHS.Registers.end(),
- II, LessRecordByID());
+ RHS.Registers.begin(), RHS.Registers.end(), II,
+ LessRecordByID());
return !Tmp.empty();
}
@@ -469,7 +470,7 @@ struct MatchableInfo {
unsigned SrcOperand2) {
ResOperand X;
X.Kind = TiedOperand;
- X.TiedOperands = { TiedOperandNum, SrcOperand1, SrcOperand2 };
+ X.TiedOperands = {TiedOperandNum, SrcOperand1, SrcOperand2};
X.MINumOperands = 1;
return X;
}
@@ -503,7 +504,7 @@ struct MatchableInfo {
Record *const TheDef;
/// DefRec - This is the definition that it came from.
- PointerUnion<const CodeGenInstruction*, const CodeGenInstAlias*> DefRec;
+ PointerUnion<const CodeGenInstruction *, const CodeGenInstAlias *> DefRec;
const CodeGenInstruction *getResultInst() const {
if (isa<const CodeGenInstruction *>(DefRec))
@@ -542,16 +543,13 @@ struct MatchableInfo {
bool UseInstAsmMatchConverter;
MatchableInfo(const CodeGenInstruction &CGI)
- : AsmVariantID(0), AsmString(CGI.AsmString), TheDef(CGI.TheDef), DefRec(&CGI),
- UseInstAsmMatchConverter(true) {
- }
+ : AsmVariantID(0), AsmString(CGI.AsmString), TheDef(CGI.TheDef),
+ DefRec(&CGI), UseInstAsmMatchConverter(true) {}
MatchableInfo(std::unique_ptr<const CodeGenInstAlias> Alias)
- : AsmVariantID(0), AsmString(Alias->AsmString), TheDef(Alias->TheDef),
- DefRec(Alias.release()),
- UseInstAsmMatchConverter(
- TheDef->getValueAsBit("UseInstAsmMatchConverter")) {
- }
+ : AsmVariantID(0), AsmString(Alias->AsmString), TheDef(Alias->TheDef),
+ DefRec(Alias.release()), UseInstAsmMatchConverter(TheDef->getValueAsBit(
+ "UseInstAsmMatchConverter")) {}
// Could remove this and the dtor if PointerUnion supported unique_ptr
// elements with a dynamic failure/assertion (like the one below) in the case
@@ -576,9 +574,8 @@ struct MatchableInfo {
void formTwoOperandAlias(StringRef Constraint);
void initialize(const AsmMatcherInfo &Info,
- SmallPtrSetImpl<Record*> &SingletonRegisters,
- AsmVariantInfo const &Variant,
- bool HasMnemonicFirst);
+ SmallPtrSetImpl<Record *> &SingletonRegisters,
+ AsmVariantInfo const &Variant, bool HasMnemonicFirst);
/// validate - Return true if this matchable is a valid thing to match against
/// and perform a bunch of validity checking.
@@ -603,9 +600,9 @@ struct MatchableInfo {
}
int findAsmOperandOriginallyNamed(StringRef N) const {
- auto I =
- find_if(AsmOperands,
- [&](const AsmOperand &Op) { return Op.OrigSrcOpName == N; });
+ auto I = find_if(AsmOperands, [&](const AsmOperand &Op) {
+ return Op.OrigSrcOpName == N;
+ });
return (I != AsmOperands.end()) ? I - AsmOperands.begin() : -1;
}
@@ -706,7 +703,7 @@ struct MatchableInfo {
struct OperandMatchEntry {
unsigned OperandMask;
- const MatchableInfo* MI;
+ const MatchableInfo *MI;
ClassInfo *CI;
static OperandMatchEntry create(const MatchableInfo *mi, ClassInfo *ci,
@@ -740,21 +737,21 @@ class AsmMatcherInfo {
std::vector<OperandMatchEntry> OperandMatchInfo;
/// Map of Register records to their class information.
- typedef std::map<Record*, ClassInfo*, LessRecordByID> RegisterClassesTy;
+ typedef std::map<Record *, ClassInfo *, LessRecordByID> RegisterClassesTy;
RegisterClassesTy RegisterClasses;
/// Map of Predicate records to their subtarget information.
std::map<Record *, SubtargetFeatureInfo, LessRecordByID> SubtargetFeatures;
/// Map of AsmOperandClass records to their class information.
- std::map<Record*, ClassInfo*> AsmOperandClasses;
+ std::map<Record *, ClassInfo *> AsmOperandClasses;
/// Map of RegisterClass records to their class information.
- std::map<Record*, ClassInfo*> RegisterClassClasses;
+ std::map<Record *, ClassInfo *> RegisterClassClasses;
private:
/// Map of token to class information which has already been constructed.
- std::map<std::string, ClassInfo*> TokenClasses;
+ std::map<std::string, ClassInfo *> TokenClasses;
private:
/// getTokenClass - Lookup or create the class for the given token.
@@ -767,7 +764,7 @@ class AsmMatcherInfo {
/// buildRegisterClasses - Build the ClassInfo* instances for register
/// classes.
- void buildRegisterClasses(SmallPtrSetImpl<Record*> &SingletonRegisters);
+ void buildRegisterClasses(SmallPtrSetImpl<Record *> &SingletonRegisters);
/// buildOperandClasses - Build the ClassInfo* instances for user defined
/// operand classes.
@@ -779,8 +776,7 @@ class AsmMatcherInfo {
MatchableInfo::AsmOperand &Op);
public:
- AsmMatcherInfo(Record *AsmParser,
- CodeGenTarget &Target,
+ AsmMatcherInfo(Record *AsmParser, CodeGenTarget &Target,
RecordKeeper &Records);
/// Construct the various tables used during matching.
@@ -798,9 +794,7 @@ class AsmMatcherInfo {
return I == SubtargetFeatures.end() ? nullptr : &I->second;
}
- RecordKeeper &getRecords() const {
- return Records;
- }
+ RecordKeeper &getRecords() const { return Records; }
bool hasOptionalOperands() const {
return any_of(Classes,
@@ -812,7 +806,8 @@ class AsmMatcherInfo {
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
LLVM_DUMP_METHOD void MatchableInfo::dump() const {
- errs() << TheDef->getName() << " -- " << "flattened:\"" << AsmString <<"\"\n";
+ errs() << TheDef->getName() << " -- "
+ << "flattened:\"" << AsmString << "\"\n";
errs() << " variant: " << AsmVariantID << "\n";
@@ -850,7 +845,7 @@ parseTwoOperandConstraint(StringRef S, ArrayRef<SMLoc> Loc) {
void MatchableInfo::formTwoOperandAlias(StringRef Constraint) {
// Figure out which operands are aliased and mark them as tied.
std::pair<StringRef, StringRef> Ops =
- parseTwoOperandConstraint(Constraint, TheDef->getLoc());
+ parseTwoOperandConstraint(Constraint, TheDef->getLoc());
// Find the AsmOperands that refer to the operands we're aliasing.
int SrcAsmOperand = findAsmOperandNamed(Ops.first);
@@ -858,11 +853,11 @@ void MatchableInfo::formTwoOperandAlias(StringRef Constraint) {
if (SrcAsmOperand == -1)
PrintFatalError(TheDef->getLoc(),
"unknown source two-operand alias operand '" + Ops.first +
- "'.");
+ "'.");
if (DstAsmOperand == -1)
PrintFatalError(TheDef->getLoc(),
"unknown destination two-operand alias operand '" +
- Ops.second + "'.");
+ Ops.second + "'.");
// Find the ResOperand that refers to the operand we're aliasing away
// and update it to refer to the combined operand instead.
@@ -878,7 +873,7 @@ void MatchableInfo::formTwoOperandAlias(StringRef Constraint) {
// Adjust the ResOperand references to any AsmOperands that followed
// the one we just deleted.
for (ResOperand &Op : ResOperands) {
- switch(Op.Kind) {
+ switch (Op.Kind) {
default:
// Nothing to do for operands that don't reference AsmOperands.
break;
@@ -892,10 +887,9 @@ void MatchableInfo::formTwoOperandAlias(StringRef Constraint) {
/// extractSingletonRegisterForAsmOperand - Extract singleton register,
/// if present, from specified token.
-static void
-extractSingletonRegisterForAsmOperand(MatchableInfo::AsmOperand &Op,
- const AsmMatcherInfo &Info,
- StringRef RegisterPrefix) {
+static void extractSingletonRegisterForAsmOperand(MatchableInfo::AsmOperand &Op,
+ const AsmMatcherInfo &Info,
+ StringRef RegisterPrefix) {
StringRef Tok = Op.Token;
// If this token is not an isolated token, i.e., it isn't separated from
@@ -922,13 +916,12 @@ extractSingletonRegisterForAsmOperand(MatchableInfo::AsmOperand &Op,
}
void MatchableInfo::initialize(const AsmMatcherInfo &Info,
- SmallPtrSetImpl<Record*> &SingletonRegisters,
+ SmallPtrSetImpl<Record *> &SingletonRegisters,
AsmVariantInfo const &Variant,
bool HasMnemonicFirst) {
AsmVariantID = Variant.AsmVariantNo;
- AsmString =
- CodeGenInstruction::FlattenAsmStringVariants(AsmString,
- Variant.AsmVariantNo);
+ AsmString = CodeGenInstruction::FlattenAsmStringVariants(
+ AsmString, Variant.AsmVariantNo);
tokenizeAsmString(Info, Variant);
@@ -936,7 +929,7 @@ void MatchableInfo::initialize(const AsmMatcherInfo &Info,
// simple string, not a $foo variable or a singleton register.
if (AsmOperands.empty())
PrintFatalError(TheDef->getLoc(),
- "Instruction '" + TheDef->getName() + "' has no tokens");
+ "Instruction '" + TheDef->getName() + "' has no tokens");
assert(!AsmOperands[0].Token.empty());
if (HasMnemonicFirst) {
@@ -1045,7 +1038,7 @@ void MatchableInfo::tokenizeAsmString(const AsmMatcherInfo &Info,
size_t EndPos = String.find('}', i);
assert(EndPos != StringRef::npos &&
"Missing brace in operand reference!");
- addAsmOperand(String.slice(i, EndPos+1), IsIsolatedToken);
+ addAsmOperand(String.slice(i, EndPos + 1), IsIsolatedToken);
Prev = EndPos + 1;
i = EndPos;
IsIsolatedToken = false;
@@ -1070,16 +1063,16 @@ bool MatchableInfo::validate(StringRef CommentDelimiter, bool IsAlias) const {
// isCodeGenOnly if they are pseudo instructions.
if (AsmString.find('\n') != std::string::npos)
PrintFatalError(TheDef->getLoc(),
- "multiline instruction is not valid for the asmparser, "
- "mark it isCodeGenOnly");
+ "multiline instruction is not valid for the asmparser, "
+ "mark it isCodeGenOnly");
// Remove comments from the asm string. We know that the asmstring only
// has one line.
if (!CommentDelimiter.empty() &&
StringRef(AsmString).contains(CommentDelimiter))
PrintFatalError(TheDef->getLoc(),
- "asmstring for instruction has comment character in it, "
- "mark it isCodeGenOnly");
+ "asmstring for instruction has comment character in it, "
+ "mark it isCodeGenOnly");
// Reject matchables with operand modifiers, these aren't something we can
// handle, the target should be refactored to use operands instead of
@@ -1092,17 +1085,17 @@ bool MatchableInfo::validate(StringRef CommentDelimiter, bool IsAlias) const {
for (const AsmOperand &Op : AsmOperands) {
StringRef Tok = Op.Token;
if (Tok[0] == '$' && Tok.contains(':'))
- PrintFatalError(TheDef->getLoc(),
- "matchable with operand modifier '" + Tok +
- "' not supported by asm matcher. Mark isCodeGenOnly!");
+ PrintFatalError(
+ TheDef->getLoc(),
+ "matchable with operand modifier '" + Tok +
+ "' not supported by asm matcher. Mark isCodeGenOnly!");
// Verify that any operand is only mentioned once.
// We reject aliases and ignore instructions for now.
if (!IsAlias && TheDef->getValueAsString("AsmMatchConverter").empty() &&
Tok[0] == '$' && !OperandNames.insert(std::string(Tok)).second) {
LLVM_DEBUG({
errs() << "warning: '" << TheDef->getName() << "': "
- << "ignoring instruction with tied operand '"
- << Tok << "'\n";
+ << "ignoring instruction with tied operand '" << Tok << "'\n";
});
return false;
}
@@ -1116,15 +1109,33 @@ static std::string getEnumNameForToken(StringRef Str) {
for (char C : Str) {
switch (C) {
- case '*': Res += "_STAR_"; break;
- case '%': Res += "_PCT_"; break;
- case ':': Res += "_COLON_"; break;
- case '!': Res += "_EXCLAIM_"; break;
- case '.': Res += "_DOT_"; break;
- case '<': Res += "_LT_"; break;
- case '>': Res += "_GT_"; break;
- case '-': Res += "_MINUS_"; break;
- case '#': Res += "_HASH_"; break;
+ case '*':
+ Res += "_STAR_";
+ break;
+ case '%':
+ Res += "_PCT_";
+ break;
+ case ':':
+ Res += "_COLON_";
+ break;
+ case '!':
+ Res += "_EXCLAIM_";
+ break;
+ case '.':
+ Res += "_DOT_";
+ break;
+ case '<':
+ Res += "_LT_";
+ break;
+ case '>':
+ Res += "_GT_";
+ break;
+ case '-':
+ Res += "_MINUS_";
+ break;
+ case '#':
+ Res += "_HASH_";
+ break;
default:
if (isAlnum(C))
Res += C;
@@ -1166,8 +1177,7 @@ AsmMatcherInfo::getOperandClass(const CGIOperandList::OperandInfo &OI,
return getOperandClass(Rec, SubOpIdx);
}
-ClassInfo *
-AsmMatcherInfo::getOperandClass(Record *Rec, int SubOpIdx) {
+ClassInfo *AsmMatcherInfo::getOperandClass(Record *Rec, int SubOpIdx) {
if (Rec->isSubClassOf("RegisterOperand")) {
// RegisterOperand may have an associated ParserMatchClass. If it does,
// use it, else just fall back to the underlying register class.
@@ -1177,7 +1187,7 @@ AsmMatcherInfo::getOperandClass(Record *Rec, int SubOpIdx) {
"Record `" + Rec->getName() +
"' does not have a ParserMatchClass!\n");
- if (DefInit *DI= dyn_cast<DefInit>(R->getValue())) {
+ if (DefInit *DI = dyn_cast<DefInit>(R->getValue())) {
Record *MatchClass = DI->getDef();
if (ClassInfo *CI = AsmOperandClasses[MatchClass])
return CI;
@@ -1186,8 +1196,9 @@ AsmMatcherInfo::getOperandClass(Record *Rec, int SubOpIdx) {
// No custom match class. Just use the register class.
Record *ClassRec = Rec->getValueAsDef("RegClass");
if (!ClassRec)
- PrintFatalError(Rec->getLoc(), "RegisterOperand `" + Rec->getName() +
- "' has no associated register class!\n");
+ PrintFatalError(Rec->getLoc(),
+ "RegisterOperand `" + Rec->getName() +
+ "' has no associated register class!\n");
if (ClassInfo *CI = RegisterClassClasses[ClassRec])
return CI;
PrintFatalError(Rec->getLoc(), "register class has no class info!");
@@ -1200,8 +1211,9 @@ AsmMatcherInfo::getOperandClass(Record *Rec, int SubOpIdx) {
}
if (!Rec->isSubClassOf("Operand"))
- PrintFatalError(Rec->getLoc(), "Operand `" + Rec->getName() +
- "' does not derive from class Operand!\n");
+ PrintFatalError(Rec->getLoc(),
+ "Operand `" + Rec->getName() +
+ "' does not derive from class Operand!\n");
Record *MatchClass = Rec->getValueAsDef("ParserMatchClass");
if (ClassInfo *CI = AsmOperandClasses[MatchClass])
return CI;
@@ -1210,19 +1222,18 @@ AsmMatcherInfo::getOperandClass(Record *Rec, int SubOpIdx) {
}
struct LessRegisterSet {
- bool operator() (const RegisterSet &LHS, const RegisterSet & RHS) const {
+ bool operator()(const RegisterSet &LHS, const RegisterSet &RHS) const {
// std::set<T> defines its own compariso "operator<", but it
// performs a lexicographical comparison by T's innate comparison
// for some reason. We don't want non-deterministic pointer
// comparisons so use this instead.
- return std::lexicographical_compare(LHS.begin(), LHS.end(),
- RHS.begin(), RHS.end(),
- LessRecordByID());
+ return std::lexicographical_compare(LHS.begin(), LHS.end(), RHS.begin(),
+ RHS.end(), LessRecordByID());
}
};
-void AsmMatcherInfo::
-buildRegisterClasses(SmallPtrSetImpl<Record*> &SingletonRegisters) {
+void AsmMatcherInfo::buildRegisterClasses(
+ SmallPtrSetImpl<Record *> &SingletonRegisters) {
const auto &Registers = Target.getRegBank().getRegisters();
auto &RegClassList = Target.getRegBank().getRegClasses();
@@ -1244,7 +1255,7 @@ buildRegisterClasses(SmallPtrSetImpl<Record*> &SingletonRegisters) {
// Introduce derived sets where necessary (when a register does not determine
// a unique register set class), and build the mapping of registers to the set
// they should classify to.
- std::map<Record*, RegisterSet> RegisterMap;
+ std::map<Record *, RegisterSet> RegisterMap;
for (const CodeGenRegister &CGR : Registers) {
// Compute the intersection of all sets containing this register.
RegisterSet ContainingSet;
@@ -1273,7 +1284,7 @@ buildRegisterClasses(SmallPtrSetImpl<Record*> &SingletonRegisters) {
}
// Construct the register classes.
- std::map<RegisterSet, ClassInfo*, LessRegisterSet> RegisterSetClasses;
+ std::map<RegisterSet, ClassInfo *, LessRegisterSet> RegisterSetClasses;
unsigned Index = 0;
for (const RegisterSet &RS : RegisterSets) {
Classes.emplace_front();
@@ -1298,9 +1309,8 @@ buildRegisterClasses(SmallPtrSetImpl<Record*> &SingletonRegisters) {
for (const RegisterSet &RS : RegisterSets) {
ClassInfo *CI = RegisterSetClasses[RS];
for (const RegisterSet &RS2 : RegisterSets)
- if (RS != RS2 &&
- std::includes(RS2.begin(), RS2.end(), RS.begin(), RS.end(),
- LessRecordByID()))
+ if (RS != RS2 && std::includes(RS2.begin(), RS2.end(), RS.begin(),
+ RS.end(), LessRecord...
[truncated]
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
arsenm
reviewed
Feb 7, 2024
|
Oh sorry, I meant; "Just before committing #80847" |
arsenm
reviewed
Feb 7, 2024
arsenm
reviewed
Feb 7, 2024
llvm/utils/TableGen/CTagsEmitter.cpp
Outdated
| @@ -1,4 +1,5 @@ | |||
| //===- CTagsEmitter.cpp - Generate ctags-compatible index ------------------===// | |||
| //===- CTagsEmitter.cpp - Generate ctags-compatible index | |||
arsenm
approved these changes
Feb 8, 2024
Pierre-vh
commented
Feb 8, 2024
There was a problem hiding this comment.
I tried my best to tag changes I found suspicious. There's a lot of noise because some files were pretty old I assume and used different indentation rules (e.g. a class inside a namespace was indented). Removing the indentation + formatting the code itself seems to prove too much for git diffing and it shows those changes as deleted/rewritten code.
| case '>': Res += "_GT_"; break; | ||
| case '-': Res += "_MINUS_"; break; | ||
| case '#': Res += "_HASH_"; break; | ||
| case '*': |
There was a problem hiding this comment.
this type of change is a bit annoying, should I revert this one and add clang-format-off/on?
There was a problem hiding this comment.
No, I really hate the fold switch case onto one line pattern
There was a problem hiding this comment.
I prefer oneline pattern :)
| case '"': Str[i] = '\"'; break; | ||
| case '\'': Str[i] = '\''; break; | ||
| case '\\': Str[i] = '\\'; break; | ||
| if (Str[i] == '\\' && i != Str.size() - 1) { |
| default: continue; // Don't execute the code after the switch. | ||
| case '{': Str[i] = '{'; break; | ||
| case '}': Str[i] = '}'; break; | ||
| if (Str[i] == '\\' && i != Str.size() - 1) { |
| default: | ||
| AddLiteralString(std::string(1, AsmString[LastEmitted])); | ||
| break; | ||
| case '\n': |
| case MVT::iPTR: return "TLI.getPointerTy()"; | ||
| case MVT::iPTRAny: return "TLI.getPointerTy()"; | ||
| default: return getEnumName(T); | ||
| case MVT::Other: |
| if (Inst.Operands.isVariadic)OS << "|(1ULL<<MCID::Variadic)"; | ||
| if (Inst.hasSideEffects) OS << "|(1ULL<<MCID::UnmodeledSideEffects)"; | ||
| if (Inst.isAsCheapAsAMove) OS << "|(1ULL<<MCID::CheapAsAMove)"; | ||
| if (Inst.isPreISelOpcode) |
There was a problem hiding this comment.
this time it's an if, might be better to also off/on clang format here?
| @@ -41,8 +41,9 @@ static inline const char *stringForContext(InstructionContext insnContext) { | |||
| break; | |||
| #define ENUM_ENTRY_K_B(n, r, d) \ | |||
| ENUM_ENTRY(n, r, d) \ | |||
| ENUM_ENTRY(n##_K_B, r, d) ENUM_ENTRY(n##_KZ, r, d) ENUM_ENTRY(n##_K, r, d) \ | |||
| ENUM_ENTRY(n##_B, r, d) ENUM_ENTRY(n##_KZ_B, r, d) | |||
| ENUM_ENTRY(n##_K_B, r, d) \ | |||
There was a problem hiding this comment.
Should I just put each ENUM_ENTRY on their own line?
chapuni
approved these changes
Feb 8, 2024
| case '>': Res += "_GT_"; break; | ||
| case '-': Res += "_MINUS_"; break; | ||
| case '#': Res += "_HASH_"; break; | ||
| case '*': |
There was a problem hiding this comment.
I prefer oneline pattern :)
Pierre-vh
force-pushed
the
format-tblgen
branch
from
c688b10
to
2d39389
Compare
``` find llvm/utils/TableGen -iname "*.h" -o -iname "*.cpp" | xargs clang-format-16 -i ```
Pierre-vh
force-pushed
the
format-tblgen
branch
from
2d39389
to
d55e428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #80847 - there is quite a bit more reformatting going on here because this is a full reformating of every file.