Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HEXAGON] Add basic block limit for RDF optimizations #81071

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

quic-asaravan
Copy link
Contributor

Skip RDF optimizations if a function contains a number of basic blocks that is more than a limit

Skip RDF optimizations if a function contains a number
of basic blocks that is more than a limit
@quic-asaravan quic-asaravan changed the title Add basic block limit for RDF optimizations [HEXAGON] Add basic block limit for RDF optimizations Feb 8, 2024
@quic-asaravan quic-asaravan reopened this Feb 8, 2024
@quic-asaravan quic-asaravan marked this pull request as ready for review February 8, 2024 07:16
@quic-asaravan
Copy link
Contributor Author

@SundeepKushwaha @iajbar Can you please review ?

Copy link
Contributor

@iajbar iajbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@iajbar iajbar self-assigned this Feb 9, 2024
@iajbar iajbar merged commit ac05771 into llvm:main Feb 9, 2024
6 checks passed
// Perform RDF optimizations only if number of basic blocks in the
// function is less than the limit
if (MF.size() > RDFFuncBlockLimit) {
LLVM_DEBUG(dbgs() << "Skipping " << getPassName()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this message is here, it might be useful/interesting to show what the number and limit are.

@quic-asaravan quic-asaravan deleted the RDF branch March 13, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants