Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TableGen] Remove map CodeGenTarget::InstrToIntMap. #81079

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

nvjle
Copy link
Contributor

@nvjle nvjle commented Feb 8, 2024

This patch removes CodeGenTarget::InstrToIntMap, using instead a new member CodeGenInstruction::EnumVal to store each enum value. This value is computed and set by CodeGenTarget::computeInstrsByEnum and queried by CodeGenTarget::getInstrIntValue.

This patch removes CodeGenTarget::InstrToIntMap, using instead a new
member CodeGenInstruction::EnumVal to store each enum value. This
value is computed and set by CodeGenTarget::computeInstrsByEnum and
queried by CodeGenTarget::getInstrIntValue.
Copy link

github-actions bot commented Feb 8, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvjle
Copy link
Contributor Author

nvjle commented Feb 8, 2024

LGTM

Thanks so much for reviewing. Could I also trouble you to merge/land (no github write yet)?

@topperc topperc merged commit d01864e into llvm:main Feb 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants