Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DWARFDump][nfc] Fix incorrect comment #81276

Merged

Conversation

felipepiovezan
Copy link
Contributor

It claimed to dump all sections by default, but this hasn't been true since 2017: https://reviews.llvm.org/D37717

@llvmbot
Copy link
Collaborator

llvmbot commented Feb 9, 2024

@llvm/pr-subscribers-debuginfo

Author: Felipe de Azevedo Piovezan (felipepiovezan)

Changes

It claimed to dump all sections by default, but this hasn't been true since 2017: https://reviews.llvm.org/D37717


Full diff: https://github.com/llvm/llvm-project/pull/81276.diff

1 Files Affected:

  • (modified) llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp (+2-2)
diff --git a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
index 559e7a60489834..74dc519c947726 100644
--- a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -845,8 +845,8 @@ int main(int argc, char **argv) {
 
   bool OffsetRequested = false;
 
-  // Defaults to dumping all sections, unless brief mode is specified in which
-  // case only the .debug_info section in dumped.
+  // Defaults to dumping only debug_info, unless verbose mode is specified in
+  // which case all sections are dumped.
 #define HANDLE_DWARF_SECTION(ENUM_NAME, ELF_NAME, CMDLINE_NAME, OPTION)        \
   if (Dump##ENUM_NAME.IsRequested) {                                           \
     DumpType |= DIDT_##ENUM_NAME;                                              \

It claimed to dump all sections by default, but this hasn't been true since
2017: https://reviews.llvm.org/D37717
@felipepiovezan felipepiovezan force-pushed the felipe/incorrect_comment_dwarfdump branch from c82ae2f to 0583356 Compare February 9, 2024 16:53
@felipepiovezan felipepiovezan merged commit 224145e into llvm:main Feb 10, 2024
3 of 4 checks passed
@felipepiovezan felipepiovezan deleted the felipe/incorrect_comment_dwarfdump branch February 10, 2024 00:01
Copy link
Collaborator

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guilty! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants