Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GlobalISel][Mips] Global ISel for brcond #81306

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

darkbuck
Copy link
Contributor

@darkbuck darkbuck commented Feb 9, 2024

  • Enable equivalent between brcond and G_BRCOND.
  • Remove the manual selection of G_BRCOND in Mips. Revise test cases.

Created using spr 1.3.4
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 9, 2024

@llvm/pr-subscribers-llvm-globalisel

Author: None (darkbuck)

Changes
  • So far, it's not used in in-tree targets.

Full diff: https://github.com/llvm/llvm-project/pull/81306.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Target/GlobalISel/SelectionDAGCompat.td (+1)
diff --git a/llvm/include/llvm/Target/GlobalISel/SelectionDAGCompat.td b/llvm/include/llvm/Target/GlobalISel/SelectionDAGCompat.td
index f792237203b431..6bc19421fb0169 100644
--- a/llvm/include/llvm/Target/GlobalISel/SelectionDAGCompat.td
+++ b/llvm/include/llvm/Target/GlobalISel/SelectionDAGCompat.td
@@ -130,6 +130,7 @@ let IfConvergent = G_INTRINSIC_CONVERGENT_W_SIDE_EFFECTS in {
 }
 
 def : GINodeEquiv<G_BR, br>;
+def : GINodeEquiv<G_BRCOND, brcond>;
 def : GINodeEquiv<G_BSWAP, bswap>;
 def : GINodeEquiv<G_BITREVERSE, bitreverse>;
 def : GINodeEquiv<G_FSHL, fshl>;

Created using spr 1.3.4
@darkbuck darkbuck changed the title [GlobalISel] Global ISel for brcond. NFC [GlobalISel][Mips] Global ISel for brcond Feb 9, 2024
Created using spr 1.3.4
Created using spr 1.3.4
Copy link
Contributor

@arsenm arsenm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe should change the description to say this is moving it to tablegen instead of suggesting it's new support

@darkbuck darkbuck merged commit d0f4663 into main Feb 11, 2024
4 checks passed
@darkbuck darkbuck deleted the users/hliao/spr/globalisel-global-isel-for-brcond-nfc branch February 11, 2024 02:44
@darkbuck
Copy link
Contributor Author

LGTM. Maybe should change the description to say this is moving it to tablegen instead of suggesting it's new support

Revise the commit message following the suggestion. But, it seems spr land uses the one posted here and discards the local change. Learned that spr diff is required to if any change (including commit message) before spr land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants