Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lld] Fix test failures when running as root user #81339

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

tstellar
Copy link
Collaborator

@tstellar tstellar commented Feb 9, 2024

This makes it easier to run the tests in a containerized environment.

This makes it easier to run the tests in a containerized environment.
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 9, 2024

@llvm/pr-subscribers-lld-coff
@llvm/pr-subscribers-lld
@llvm/pr-subscribers-lld-elf

@llvm/pr-subscribers-lld-macho

Author: Tom Stellard (tstellar)

Changes

This makes it easier to run the tests in a containerized environment.


Full diff: https://github.com/llvm/llvm-project/pull/81339.diff

7 Files Affected:

  • (modified) lld/test/COFF/lto-cache-errors.ll (+1-1)
  • (modified) lld/test/COFF/thinlto-emit-imports.ll (+1-1)
  • (modified) lld/test/ELF/lto/resolution-err.ll (+1-1)
  • (modified) lld/test/ELF/lto/thinlto-cant-write-index.ll (+1-1)
  • (modified) lld/test/ELF/lto/thinlto-emit-imports.ll (+1-1)
  • (modified) lld/test/MachO/invalid/invalid-lto-object-path.ll (+1-1)
  • (modified) lld/test/MachO/thinlto-emit-imports.ll (+1-1)
diff --git a/lld/test/COFF/lto-cache-errors.ll b/lld/test/COFF/lto-cache-errors.ll
index 55244e5690dc34..a46190a81b6230 100644
--- a/lld/test/COFF/lto-cache-errors.ll
+++ b/lld/test/COFF/lto-cache-errors.ll
@@ -1,4 +1,4 @@
-; REQUIRES: x86
+; REQUIRES: x86, non-root-user
 ;; Not supported on windows since we use permissions to deny the creation
 ; UNSUPPORTED: system-windows
 
diff --git a/lld/test/COFF/thinlto-emit-imports.ll b/lld/test/COFF/thinlto-emit-imports.ll
index a9f22c1dc2dcff..b47a6cea4eb7df 100644
--- a/lld/test/COFF/thinlto-emit-imports.ll
+++ b/lld/test/COFF/thinlto-emit-imports.ll
@@ -1,4 +1,4 @@
-; REQUIRES: x86
+; REQUIRES: x86, non-root-user
 
 ; Generate summary sections and test lld handling.
 ; RUN: opt -module-summary %s -o %t1.obj
diff --git a/lld/test/ELF/lto/resolution-err.ll b/lld/test/ELF/lto/resolution-err.ll
index 6dfa64b1b8b9ee..f9855abaff3279 100644
--- a/lld/test/ELF/lto/resolution-err.ll
+++ b/lld/test/ELF/lto/resolution-err.ll
@@ -1,5 +1,5 @@
 ; UNSUPPORTED: system-windows
-; REQUIRES: shell
+; REQUIRES: shell, non-root-user
 ; RUN: llvm-as %s -o %t.bc
 ; RUN: touch %t.resolution.txt
 ; RUN: chmod u-w %t.resolution.txt
diff --git a/lld/test/ELF/lto/thinlto-cant-write-index.ll b/lld/test/ELF/lto/thinlto-cant-write-index.ll
index e664acbb17de1a..286fcddd4238a1 100644
--- a/lld/test/ELF/lto/thinlto-cant-write-index.ll
+++ b/lld/test/ELF/lto/thinlto-cant-write-index.ll
@@ -1,4 +1,4 @@
-; REQUIRES: x86
+; REQUIRES: x86, non-root-user
 
 ; Basic ThinLTO tests.
 ; RUN: opt -module-summary %s -o %t1.o
diff --git a/lld/test/ELF/lto/thinlto-emit-imports.ll b/lld/test/ELF/lto/thinlto-emit-imports.ll
index 6d0e1e65047db4..253ec08619c982 100644
--- a/lld/test/ELF/lto/thinlto-emit-imports.ll
+++ b/lld/test/ELF/lto/thinlto-emit-imports.ll
@@ -1,4 +1,4 @@
-; REQUIRES: x86
+; REQUIRES: x86, non-root-user
 ;; Test a few properties not tested by thinlto-index-only.ll
 
 ; RUN: opt -module-summary %s -o %t1.o
diff --git a/lld/test/MachO/invalid/invalid-lto-object-path.ll b/lld/test/MachO/invalid/invalid-lto-object-path.ll
index 75c6a97e446fb2..c862538d592ce8 100644
--- a/lld/test/MachO/invalid/invalid-lto-object-path.ll
+++ b/lld/test/MachO/invalid/invalid-lto-object-path.ll
@@ -1,4 +1,4 @@
-; REQUIRES: x86
+; REQUIRES: x86, non-root-user
 
 ;; Creating read-only directories with `chmod 400` isn't supported on Windows
 ; UNSUPPORTED: system-windows
diff --git a/lld/test/MachO/thinlto-emit-imports.ll b/lld/test/MachO/thinlto-emit-imports.ll
index 47a612bd0a7b56..88f766f59c8877 100644
--- a/lld/test/MachO/thinlto-emit-imports.ll
+++ b/lld/test/MachO/thinlto-emit-imports.ll
@@ -1,4 +1,4 @@
-; REQUIRES: x86
+; REQUIRES: x86, non-root-user
 ; RUN: rm -rf %t; split-file %s %t
 
 ; Generate summary sections and test lld handling.

@int3
Copy link
Contributor

int3 commented Feb 10, 2024

Just curious, what were the failure messages?

@tstellar
Copy link
Collaborator Author

Just curious, what were the failure messages?

All the tests that check file permissions fail when you run as root. Here are some logs: https://github.com/tstellar/llvm-project/actions/runs/7830600066/job/21365140565

@tstellar tstellar merged commit e165bea into llvm:main Feb 10, 2024
8 of 9 checks passed
@tstellar tstellar added this to the LLVM 18.X Release milestone Feb 16, 2024
@tstellar
Copy link
Collaborator Author

/cherry-pick e165bea

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 16, 2024
This makes it easier to run the tests in a containerized environment.

(cherry picked from commit e165bea)
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 16, 2024

/pull-request #81988

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 16, 2024
This makes it easier to run the tests in a containerized environment.

(cherry picked from commit e165bea)
@pointhex pointhex mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants