Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT] Add support for Linux kernel static calls table #82072

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

maksfb
Copy link
Contributor

@maksfb maksfb commented Feb 16, 2024

Static calls are calls that are getting patched during runtime. Hence, for every such call the kernel runtime needs the location of the call or jmp instruction that will be patched. Instruction locations together with a corresponding key are stored in the static call site table. As BOLT rewrites these instructions it needs to update the table.

Static calls are calls that are getting patched during runtime. Hence,
for every such call the kernel runtime needs the location of the call
or jmp instruction that will be patched. Instruction locations together
with a corresponding key are stored in the static call site table.
As BOLT rewrites these instructions it needs to update the table.
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please address the comment about using streams before landing.

bolt/lib/Rewrite/LinuxKernelRewriter.cpp Show resolved Hide resolved
Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG After you fix Amir's comment

@maksfb
Copy link
Contributor Author

maksfb commented Feb 19, 2024

LG After you fix Amir's comment

LinuxKernelRewriter needs a different PR to switch to BC streams.

@maksfb
Copy link
Contributor Author

maksfb commented Feb 19, 2024

Thanks for the review.

@maksfb maksfb merged commit 2646dcc into llvm:main Feb 19, 2024
6 checks passed
@maksfb maksfb deleted the gh-static-calls branch March 28, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants