Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT] Set EntryDiscriminator in YAML profile for indirect calls #82128

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Feb 17, 2024

Indirect call handling missed setting an EntryDiscriminator while it's
set for direct calls and tail calls.

Improve YAML profile accuracy by unifying the destination setting
between direct and indirect calls into setCSIDestination method.

Depends on: #86848

Test Plan:
Updated bolt/test/X86/yaml-secondary-entry-discriminator.s

aaupov and others added 6 commits March 21, 2024 16:37
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4
Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also address the issue with enumeration of secondary entry points:
make them start with 1 instead of 0 (reserved for primary entry point).

^ do you want to split this in a separate commit?

@aaupov
Copy link
Contributor Author

aaupov commented Mar 27, 2024

Also address the issue with enumeration of secondary entry points:
make them start with 1 instead of 0 (reserved for primary entry point).

^ do you want to split this in a separate commit?

Makes sense. Will do.

@aaupov
Copy link
Contributor Author

aaupov commented Mar 27, 2024

Split out into #86848 (WIP)

aaupov and others added 2 commits March 27, 2024 11:29
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
aaupov and others added 2 commits March 27, 2024 14:48
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Copy link
Contributor

@maksfb maksfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aaupov and others added 2 commits March 27, 2024 15:49
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
@aaupov aaupov changed the base branch from users/aaupov/spr/main.bolt-set-entrydiscriminator-in-yaml-profile-for-indirect-calls to main March 27, 2024 23:40
@aaupov aaupov merged commit 385e3e2 into main Mar 27, 2024
5 checks passed
@aaupov aaupov deleted the users/aaupov/spr/bolt-set-entrydiscriminator-in-yaml-profile-for-indirect-calls branch March 27, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants