-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOLT] Set EntryDiscriminator in YAML profile for indirect calls #82128
[BOLT] Set EntryDiscriminator in YAML profile for indirect calls #82128
Conversation
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Created using spr 1.3.4
…yIDForSymbol Created using spr 1.3.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also address the issue with enumeration of secondary entry points:
make them start with 1 instead of 0 (reserved for primary entry point).
^ do you want to split this in a separate commit?
Makes sense. Will do. |
Split out into #86848 (WIP) |
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
Indirect call handling missed setting an
EntryDiscriminator
while it'sset for direct calls and tail calls.
Improve YAML profile accuracy by unifying the destination setting
between direct and indirect calls into
setCSIDestination
method.Depends on: #86848
Test Plan:
Updated bolt/test/X86/yaml-secondary-entry-discriminator.s