[CMake] Enable new policy for CMAKE_MSVC_DEBUG_INFORMATION_FORMAT #82371
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
Oh, and in addition to the comment wording suggestion, I think we also should change the subject of the PR (which also becomes the subject of the commit after merging), to indicate what actually changes - a cmake policy affecting how the project is built for everybody, in msvc mode. E.g. Subject: |
dabrahams
changed the title
Done. |
cmake/Modules/CMakePolicy.cmake
Outdated
| @@ -10,3 +10,17 @@ endif() | |||
| if(POLICY CMP0116) | |||
| cmake_policy(SET CMP0116 OLD) | |||
| endif() | |||
|
|
|||
| +# Enable debug info compatible with SCCache | |||
There was a problem hiding this comment.
At this point, this first line feels a bit out of place (and kinda redundant with the stuff on lines 20-23 below), can we just remove this one?
There was a problem hiding this comment.
Ping - if you'd have time to update this to remove the first comment line here, I'd be ok with merging this.
|
@dabrahams Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
| # (https://github.com/mozilla/sccache?tab=readme-ov-file#usage) | ||
| # avoiding “fatal error C1041: cannot open program database; if | ||
| # multiple CL.EXE write to the same .PDB file, please use /FS" | ||
| +if(POLICY CMP0141) |
There was a problem hiding this comment.
Actually, here, an extra + char had slipped in at the start of each line, breaking every single buildbot we have. But I pushed a fix in 1b945e3.
No description provided.