Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SystemZ] Add SystemZ path for the PR labeler #82515

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

redstar
Copy link
Member

@redstar redstar commented Feb 21, 2024

Similar to #82200:
Add paths for SystemZ related changes to the PR labeler.

There is no pr-subscribers-backend:SystemZ team in the llvm org yet.
Much appreciated if some admin can help to create the team.

Similar to llvm#82200:
Add paths for SystemZ related changes to the PR labeler.

There is no pr-subscribers-backend:SystemZ team in the llvm org yet.
Much appreciated if some admin can help to create the team.
@redstar redstar self-assigned this Feb 21, 2024
@redstar redstar marked this pull request as ready for review February 21, 2024 18:15
Copy link
Collaborator

@tstellar tstellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaskRay
Copy link
Member

MaskRay commented Feb 21, 2024

Am I right that **/SystemZ/** is not supported by the labeler so that all paths have to be enumerated?

@redstar
Copy link
Member Author

redstar commented Feb 22, 2024

Am I right that **/SystemZ/** is not supported by the labeler so that all paths have to be enumerated?

The documentation for the labeler refers to the minimatch module, and the doc there states:

The double-star character ** is supported by default, (...)

So it should work.

@redstar redstar merged commit 8e28037 into llvm:main Feb 22, 2024
7 checks passed
@redstar redstar deleted the knacke/systemzpathlabeler branch April 16, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants