lldbDataFormatters: fix type error in StringRef printer

[arichardson]

It appears we cannot use keyword arguments for GetPointeeData() and instead have to rely on positional arguments.

Traceback (most recent call last):
  File ".../llvm-project/llvm/utils/lldbDataFormatters.py", line 245, in StringRefSummaryProvider
    data = valobj.GetChildAtIndex(0).GetPointeeData(item_count=length)
TypeError: GetPointeeData() got an unexpected keyword argument 'item_count'

[adrian-prantl]

The patch is clearly semantically equivalent to the existing code and correct. But @JDevlieghere why wouldn't the keyword argument work?

[adrian-prantl]

https://lldb.llvm.org/python_api/lldb.SBValue.html#lldb.SBValue.GetPointeeData

[JDevlieghere]

This should work (and does work locally for me). The only explanation I can think of is that this is being called with (older) bindings that don't have the variable names, but it seems to have been like this forever.

What version of LLDB and Python are you using? If you know where the Python bindings live, it would be great to look at the signature of the function. For me it looks like this:

    def GetPointeeData(self, item_idx=0, item_count=1):
       ...

[arichardson]

This should work (and does work locally for me). The only explanation I can think of is that this is being called with (older) bindings that don't have the variable names, but it seems to have been like this forever.

What version of LLDB and Python are you using? If you know where the Python bindings live, it would be great to look at the signature of the function. For me it looks like this:

    def GetPointeeData(self, item_idx=0, item_count=1):
       ...

I am using LLDB bundled with CLion, I will see if I can find the Python bindings.

[arichardson]

I see the following in ~/.local/share/JetBrains/Toolbox/apps/clion/bin/lldb/linux/x64/lib/python3.8/site-packages/lldb/__init__.py:16674: def GetPointeeData(self, *args) -> "lldb::SBData":.

I will file an issue with Jetbrains to see if they can adjust their bindings generation to emit named arguments.

[arichardson]

Reported to Jetbrains as https://youtrack.jetbrains.com/issue/CPP-37686 (@broadwaylamb not sure if you're the right person to investigate this?)

[broadwaylamb]

Reported to Jetbrains as https://youtrack.jetbrains.com/issue/CPP-37686 (@broadwaylamb not sure if you're the right person to investigate this?)

Not quite, but I'm sure folks from the CLion team will do their best :)

Thank you for creating the ticket btw.

[arichardson]

It sounds like this has been fixed in CLion 2024.1. I'm not sure if we should still merge this for older versions or just close it.