Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix formatting so CI can continue #82721

Closed
wants to merge 0 commits into from

Conversation

AtariDreams
Copy link
Contributor

@AtariDreams AtariDreams commented Feb 23, 2024

These keep tripping up the build bots for clang and preventing libc++ tests from proceeding.

@llvmbot llvmbot added clang Clang issues not falling into any other category HLSL HLSL Language Support labels Feb 23, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 23, 2024

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-hlsl

Author: AtariDreams (AtariDreams)

Changes

These keep tripping up the build bots for clang and preventing testing on libc to go forward.


Full diff: https://github.com/llvm/llvm-project/pull/82721.diff

1 Files Affected:

  • (modified) clang/docs/HLSL/ExpectedDifferences.rst (+2-2)
diff --git a/clang/docs/HLSL/ExpectedDifferences.rst b/clang/docs/HLSL/ExpectedDifferences.rst
index 60001b22dc7920..d1b6010f10f43a 100644
--- a/clang/docs/HLSL/ExpectedDifferences.rst
+++ b/clang/docs/HLSL/ExpectedDifferences.rst
@@ -93,7 +93,7 @@ behavior between Clang and DXC. Some examples include:
     fma(X, Y, Z); // DXC: Fails to resolve no known conversion from float to double.
                   // Clang: Resolves to fma(double,double,double).
   #endif
-    
+
     double D = dot(A, B); // DXC: Resolves to dot(double3, double3), fails DXIL Validation.
                           // FXC: Expands to compute double dot product with fmul/fadd
                           // Clang: Resolves to dot(float3, float3), emits conversion warnings.
@@ -102,7 +102,7 @@ behavior between Clang and DXC. Some examples include:
 
 .. note::
 
-  In Clang, a conscious decision was made to exclude the ``dot(vector<double,N>, vector<double,N>)`` 
+  In Clang, a conscious decision was made to exclude the ``dot(vector<double,N>, vector<double,N>)``
   overload and allow overload resolution to resolve the
   ``vector<float,N>`` overload. This approach provides ``-Wconversion``
   diagnostic notifying the user of the conversion rather than silently altering

Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@AtariDreams AtariDreams changed the title [NFC] Fix clang format errors [NFC] Fix formatting so CI can continue Feb 23, 2024
@llvm-beanz
Copy link
Collaborator

Do you have a link to the CI that failed this? The official clang doc build succeeded and published the docs.

@AtariDreams
Copy link
Contributor Author

Do you have a link to the CI that failed this? The official clang doc build succeeded and published the docs.

https://buildkite.com/llvm-project/github-pull-requests/builds/41428

@AtariDreams AtariDreams force-pushed the Fix-clang-format-warnings branch 2 times, most recently from 4f6119a to 769828b Compare February 24, 2024 05:52
@AtariDreams AtariDreams deleted the Fix-clang-format-warnings branch February 25, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category HLSL HLSL Language Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants