[compiler-rt] fix BSD procmaps stack size limit on build due to the k…

[devnexen]

…info_proc type.

[llvmbot]

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: David CARLIER (devnexen)

Changes

…info_proc type.

---

Full diff: https://github.com/llvm/llvm-project/pull/82887.diff

1 Files Affected:

• (modified) compiler-rt/lib/sanitizer_common/sanitizer_procmaps_bsd.cpp (+7-4)

diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_procmaps_bsd.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_procmaps_bsd.cpp
index dcfd94fe3225cd..3649bfd1b25b12 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_procmaps_bsd.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_procmaps_bsd.cpp
@@ -37,10 +37,13 @@ void GetMemoryProfile(fill_profile_f cb, uptr *stats) {
     getpid()
   }; 
 
-  struct kinfo_proc InfoProc;
-  uptr Len = sizeof(InfoProc);
-  CHECK_EQ(internal_sysctl(Mib, ARRAY_SIZE(Mib), nullptr, (uptr *)&InfoProc, &Len, 0), 0);
-  cb(0, InfoProc.ki_rssize * GetPageSizeCached(), false, stats);
+  struct kinfo_proc *InfoProc;
+  uptr Len = sizeof(*InfoProc);
+  uptr Size = Len;
+  InfoProc = (struct kinfo_proc *)MmapOrDie(Size, "GetMemoryProfile()");
+  CHECK_EQ(internal_sysctl(Mib, ARRAY_SIZE(Mib), nullptr, (uptr *)InfoProc, &Len, 0), 0);
+  cb(0, InfoProc->ki_rssize * GetPageSizeCached(), false, stats);
+  UnmapOrDie(InfoProc, Size, true);
 }
 #endif
 

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[vitalybuka]

stack size of stack frame size limit?
if the latter, maybe noinline on the function is better fix?

[devnexen]

if you meant adding NOINLINE it fixes nothing.

[vitalybuka]

would it be possible fixup title to avoid line break?

How bit this struct? Or what is error message?

I would prefer RAII with InternalScopedVector<kinfo_proc> of size 1

[devnexen]

would it be possible fixup title to avoid line break?

How bit this struct? Or what is error message?

1088 :)