[OpenMP] Implements __kmp_is_address_mapped for Solaris/Illumos.

[devnexen]

Also fixing OpenMP build itself for this platform.

[brad0]

It was already known that illumos was not building with the __kmp_set_stack_info() function due to the difference in non-portable POSIX thread functions implemented by Solaris vs illumos.

From reading the man page I question whether you can mix Solaris threads and POSIX threads functions together.

CC @rorth

[rorth]

You can. See threads(7):

NAME
       threads, pthreads - POSIX pthreads and Solaris threads concepts

SYNOPSIS
   POSIX
       #include <pthread.h>

   Solaris
       #include <sched.h>

       #include <thread.h>

DESCRIPTION
       POSIX  and  Solaris  threads  each have their own implementation within
       libc(3LIB). Both implementations are interoperable, their functionality
       similar,  and  can  be  used  within  the  same application. Only POSIX

[rorth]

Also, please state where you tested the patch. Illumos only, Solaris, which version?

[devnexen]

I tried on an Illumos based distro (openinidiana), note that illumos supports pthread_attr_get_np but not solaris.

[brad0]

That looks better.

[rorth]

Not a full review, just two comments.

[rorth]

Why restrict the code to __LP64__? openmp is 64-bit-only anyway.

[rorth]

(GH is driving me nuts: lost part of my comments for the second time ;-()

Why do things this way? The documented way to access procfs is to just include <procfs.h> (which deals with _STRUCTURED_PROC internally).

[devnexen]

I did not know procfs.h did all, handy.

[rorth]

I tried on an Illumos based distro (openinidiana), note that illumos supports pthread_attr_get_np but not solaris.

So you're adding a third variant when a simple conditional to distinguish between Solaris and Illumos would do? And how will you handle some case where there's no common ground between the two?

The Illumos community finally needs to deal with Issue #53919: @MaskRay asked me to file it two years ago when running into Illumos/Solaris differences wrt. dlpi_tls_modid in struct dl_phdr_info and stop worrying about Illumos until they got this Issue resolved. Two years later and not a thing has happened...

[devnexen]

I tried on an Illumos based distro (openinidiana), note that illumos supports pthread_attr_get_np but not solaris.

So you're adding a third variant when a simple conditional to distinguish between Solaris and Illumos would do? And how will you handle some case where there's no common ground between the two?

The Illumos community finally needs to deal with Issue #53919: @MaskRay asked me to file it two years ago when running into Illumos/Solaris differences wrt. dlpi_tls_modid in struct dl_phdr_info and stop worrying about Illumos until they got this Issue resolved. Two years later and not a thing has happened...

Unfortunately, it s the reality of OSS ; for now I m using an old api present in both proprietary and opensolaris descendants :) I realise now that even sanitizers use it too.