-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMDGPU] promote i1 arg type for amdgpu_cs #82971
Conversation
@llvm/pr-subscribers-backend-amdgpu Author: Nick Anderson (nickleus27) Changesfixes #68087 Full diff: https://github.com/llvm/llvm-project/pull/82971.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUCallingConv.td b/llvm/lib/Target/AMDGPU/AMDGPUCallingConv.td
index c5207228dc913f..a988140df3e89b 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUCallingConv.td
+++ b/llvm/lib/Target/AMDGPU/AMDGPUCallingConv.td
@@ -66,6 +66,7 @@ def RetCC_SI_Gfx : CallingConv<[
def CC_SI_SHADER : CallingConv<[
+ CCIfType<[i1], CCPromoteToType<i16>>,
CCIfInReg<CCIfType<[f32, i32, f16, i16, v2i16, v2f16, bf16, v2bf16] , CCAssignToReg<[
SGPR0, SGPR1, SGPR2, SGPR3, SGPR4, SGPR5, SGPR6, SGPR7,
SGPR8, SGPR9, SGPR10, SGPR11, SGPR12, SGPR13, SGPR14, SGPR15,
|
test/CodeGen/AMDGPU/calling-conventions.ll is probably the best bet right now (although I'm not happy with how these tests are organized) Both inreg and not inreg should be promoted. The inreg just flips from VGPR to SGPR. |
42c132d
to
e5fbf6a
Compare
e5fbf6a
to
6b4caa8
Compare
Hi, while you're at it, could you please make the same change for |
fixes #68087
Not sure where to put regression tests for this pr? Also, should i1 args not in reg also be promoted?