[compiler-rt] Build libfuzzer sources with the chosen C++ compiler #83090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
Created using spr 1.3.4
vitalybuka
approved these changes
Feb 29, 2024
In my build environment, the output is a relative path: ``` test/dfsan/reaches_function.c:34 add.dfsan test/dfsan/reaches_function.c:56 main ``` This fixes check-dfsan in my configuration: ``` cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja -DCMAKE_C_COMPILER=$HOME/output/upstream-llvm/bin/clang -DCMAKE_CXX_COMPILER=$HOME/output/upstream-llvm/bin/clang++ -DCOMPILER_RT_INCLUDE_TESTS=ON -DLLVM_EXTERNAL_LIT=$HOME/build/upstream-llvm-project-build/bin/llvm-lit -DLLVM_CMAKE_DIR=$HOME/output/upstream-llvm -DCOMPILER_RT_DEBUG=OFF -S $HOME/src/upstream-llvm-project/compiler-rt -B $HOME/src/upstream-llvm-project/compiler-rt/cmake-build-all-sanitizers ``` Reviewers: browneee, vitalybuka Reviewed By: vitalybuka Pull Request: #83089
Created using spr 1.3.4
Created using spr 1.3.4
arichardson
added a commit
that referenced
this pull request
Mar 2, 2024
I was getting build failures due to missing <cstddef> when building the libfuzzer tests. It turns out that the custom command was using COMPILER_RT_TEST_COMPILER when building the source file rather than the COMPILER_RT_TEST_CXX_COMPILER. Pull Request: #83090
arichardson
deleted the
users/arichardson/spr/compiler-rt-build-libfuzzer-sources-with-the-chosen-c-compiler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting build failures due to missing when building the
libfuzzer tests. It turns out that the custom command was using
COMPILER_RT_TEST_COMPILER when building the source file rather than
the COMPILER_RT_TEST_CXX_COMPILER.