Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc] fix most clang-tidy llvm-header-guard warnings #83319

Closed
wants to merge 1 commit into from
Closed

[libc] fix most clang-tidy llvm-header-guard warnings #83319

wants to merge 1 commit into from

Commits on Feb 28, 2024

  1. [libc] fix most clang-tidy llvm-header-guard warnings 

    To filter just these warnings:
    $ ninja -k2000 libc-lint 2>&1 | grep llvm-header-guard

To automatically apply fixits:
    $ find libc/src libc/include libc/test -name \*.h | \
      xargs -n1 -I {} clang-tidy {} -p build/compile_commands.json \
        -checks='-*,llvm-header-guard' --fix --quiet

Some manual cleanup is still necessary as headers that were missing header
guards outright will have them inserted before the license block (we prefer
them after).

There's a few remaining llvm-header-guard warning I'm tracking down separately
and will have a separate PR for those.
    @nickdesaulniers
    nickdesaulniers committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    76c59ab View commit details
    Browse the repository at this point in the history