Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of [temp.param]p14's first sentence. #83487

Merged
merged 4 commits into from Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions clang/lib/Sema/SemaTemplate.cpp
Expand Up @@ -3141,12 +3141,14 @@ bool Sema::CheckTemplateParameterList(TemplateParameterList *NewParams,
diag::note_template_param_prev_default_arg_in_other_module)
<< PrevModuleName;
Invalid = true;
} else if (MissingDefaultArg && TPC != TPC_FunctionTemplate) {
// C++ [temp.param]p11:
// If a template-parameter of a class template has a default
// template-argument, each subsequent template-parameter shall either
// have a default template-argument supplied or be a template parameter
// pack.
} else if (MissingDefaultArg &&
(TPC == TPC_ClassTemplate || TPC == TPC_FriendClassTemplate ||
TPC == TPC_VarTemplate || TPC == TPC_TypeAliasTemplate)) {
// C++ 23[temp.param]p14:
// If a template-parameter of a class template, variable template, or
// alias template has a default template argument, each subsequent
// template-parameter shall either have a default template argument
// supplied or be a template parameter pack.
Diag((*NewParam)->getLocation(),
diag::err_template_param_default_arg_missing);
Diag(PreviousDefaultArgLoc, diag::note_template_param_prev_default_arg);
Expand Down
60 changes: 60 additions & 0 deletions clang/test/SemaCXX/GH83461.cpp
@@ -0,0 +1,60 @@
// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s

struct S {
template<typename Ty = int>
friend void foo(auto){}

template<typename Ty = int, typename Tz>
friend void foo2(){}
};

template<typename T>
struct TemplS {
template<typename Ty = int>
friend void foo3(auto){}

template<typename Ty = int, typename Tz>
friend void foo4(){}
};

void Inst() {
TemplS<int>();
}
// expected-error@+2{{template parameter missing a default argument}}
// expected-note@+1{{previous default template argument defined here}}
template<typename T = int, typename U>
struct ClassTempl{};

struct HasFriendClassTempl {
// expected-error@+1{{default template argument not permitted on a friend template}}
template<typename T = int, typename U>
friend struct Friend;

// expected-error@+3{{cannot define a type in a friend declaration}}
// expected-error@+1{{default template argument not permitted on a friend template}}
template<typename T = int, typename U>
friend struct Friend2{};
};

template<typename Ty>
struct HasFriendClassTempl2 {
// expected-error@+3{{template parameter missing a default argument}}
// expected-note@+2{{previous default template argument defined here}}
// expected-note@#INST2{{in instantiation of template class}}
template<typename T = int, typename U>
friend struct Friend;
};

void Inst2() {
HasFriendClassTempl2<int>(); // #INST2
}

// expected-error@+2{{template parameter missing a default argument}}
// expected-note@+1{{previous default template argument defined here}}
template<typename T = int, typename U>
static constexpr U VarTempl;

// expected-error@+2{{template parameter missing a default argument}}
// expected-note@+1{{previous default template argument defined here}}
template<typename T = int, typename U>
using TypeAlias = U;