[BOLT] support AArch64 JUMP26 createRelocation #83531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linsinan1995
requested review from
aaupov,
maksfb,
rafaelauler,
ayermolo and
dcci
as code owners
yota9
reviewed
Mar 1, 2024
| // 12: b func2 | ||
| // 16: func2 | ||
|
|
||
| char Data[20] = {}; |
There was a problem hiding this comment.
Test is failing, probably due to using stack array here.
linsinan1995
force-pushed
the
add-jump26-createReloc
branch
from
981f308
to
ff39b07
Compare
yota9
reviewed
Mar 4, 2024
| // 12: b func2 | ||
| // 16: func2 | ||
|
|
||
| uint64_t Size = 20; |
Add R_AARCH64_JUMP26 implementation for createRelocation, which could significantly reduce the number of failed scan-refs cases.
linsinan1995
force-pushed
the
add-jump26-createReloc
branch
from
ff39b07
to
78ec69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add R_AARCH64_JUMP26 implementation for createRelocation, which could significantly reduce the number of failed scan-refs cases if we perform bolt on a selective range of functions. The implementation is based on CALL26 createRelocation.