Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DiagnosticInfo] Set correct DiagnosticKind for DiagnosticInfoIgnoringInvalidDebugMetadata class #83680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antlilja
Copy link

@antlilja antlilja commented Mar 2, 2024

LLVM currently sets the diagnostic kind for DiagnosticInfoIgnoringInvalidDebugMetadata as DK_DebugMetadataVersion instead of DK_DebugMetadataInvalid meaning that the output of classof is incorrect.

Copy link

github-actions bot commented Mar 2, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the llvm:ir label Mar 2, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 2, 2024

@llvm/pr-subscribers-llvm-ir

Author: Anton Lilja (antlilja)

Changes

LLVM currently sets the diagnostic kind for DiagnosticInfoIgnoringInvalidDebugMetadata as DK_DebugMetadataVersion instead of DK_DebugMetadataInvalid meaning that the output of classof is incorrect.


Full diff: https://github.com/llvm/llvm-project/pull/83680.diff

1 Files Affected:

  • (modified) llvm/include/llvm/IR/DiagnosticInfo.h (+1-1)
diff --git a/llvm/include/llvm/IR/DiagnosticInfo.h b/llvm/include/llvm/IR/DiagnosticInfo.h
index 628445fe9fb2cc..51356e37347fe4 100644
--- a/llvm/include/llvm/IR/DiagnosticInfo.h
+++ b/llvm/include/llvm/IR/DiagnosticInfo.h
@@ -219,7 +219,7 @@ class DiagnosticInfoIgnoringInvalidDebugMetadata : public DiagnosticInfo {
   /// \p The module that is concerned by this debug metadata version diagnostic.
   DiagnosticInfoIgnoringInvalidDebugMetadata(
       const Module &M, DiagnosticSeverity Severity = DS_Warning)
-      : DiagnosticInfo(DK_DebugMetadataVersion, Severity), M(M) {}
+      : DiagnosticInfo(DK_DebugMetadataInvalid, Severity), M(M) {}
 
   const Module &getModule() const { return M; }
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants