[Github] Make CI container build more reliable #83707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch increases the reliability of the CI container build (that was failing consistently before this patch) by fixing some transient space issues. During the stage2 build setup, the tar archive was pulled in from the artifact and placed into $GITHUB_WORKSPACE, almost filling it. Podman while running podman load uses additional space on the same drive as $GITHUB_WORKSPACE, eventually running out of space. This patch moves the downloaded tar archive to /mnt/podman, which has significantly more space, and avoids this problem. Fixes llvm#83142.
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch increases the reliability of the CI container build (that was failing consistently before this patch) by fixing some transient space issues. During the stage2 build setup, the tar archive was pulled in from the artifact and placed into $GITHUB_WORKSPACE, almost filling it. Podman while running podman load uses additional space on the same drive as $GITHUB_WORKSPACE, eventually running out of space. This patch moves the downloaded tar archive to /mnt/podman, which has significantly more space, and avoids this problem. Fixes #83142. Full diff: https://github.com/llvm/llvm-project/pull/83707.diff 1 Files Affected:
diff --git a/.github/workflows/build-ci-container.yml b/.github/workflows/build-ci-container.yml
index 3f2bf57eb85088..28fc7de2ee0654 100644
--- a/.github/workflows/build-ci-container.yml
+++ b/.github/workflows/build-ci-container.yml
@@ -77,14 +77,18 @@ jobs:
cp ./.github/workflows/containers/github-action-ci/storage.conf ~/.config/containers/storage.conf
podman info
+ # Download the container image into /mnt/podman rather than
+ # $GITHUB_WORKSPACE to avoid space limitations on the default drive
+ # and use the permissions setup for /mnt/podman.
- name: Download stage1-toolchain
uses: actions/download-artifact@v4
with:
name: stage1-toolchain
+ path: /mnt/podman
- name: Load stage1-toolchain
run: |
- podman load -i stage1-toolchain.tar
+ podman load -i /mnt/podman/stage1-toolchain.tar
- name: Build Container
working-directory: ./.github/workflows/containers/github-action-ci/
|
tstellar
approved these changes
Mar 3, 2024
|
Thanks for looking into this @boomanaiden154 ! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch increases the reliability of the CI container build (that was failing consistently before this patch) by fixing some transient space issues. During the stage2 build setup, the tar archive was pulled in from the artifact and placed into $GITHUB_WORKSPACE, almost filling it. Podman while running podman load uses additional space on the same drive as $GITHUB_WORKSPACE, eventually running out of space. This patch moves the downloaded tar archive to /mnt/podman, which has significantly more space, and avoids this problem.
Fixes #83142.