[OpenMP][macOS] Add the implementation of __divdc3 and __divsc3
#83767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple Silicon macOS doesn't have the two functions coming with their `libgcc`. This causes a link error when compiling OpenMP. `compiler-rt` has the implementation of the two functions but users may not always have that enabled, either when using the system compiler or building LLVM manually. This patch simply adds the imlementation of the two functions and only includes them on Apple Silicon macOS. Fix llvm#54596.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple Silicon macOS doesn't have the two functions coming with their
libgcc.This causes a link error when compiling OpenMP.
compiler-rthas theimplementation of the two functions but users may not always have that enabled,
either when using the system compiler or building LLVM manually.
This patch simply adds the imlementation of the two functions and only includes
them on Apple Silicon macOS.
Fix #54596.