[mlir][nvvm] Add missing include to llvm-config.h. #83998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NVVM/Target.cpp` uses the macro `MLIR_NVPTXCOMPILER_ENABLED`, which is defined in `llvm-config.h` but did not include that file, yielding a warning when compiled with `-Wundef`. This PR adds the include.
|
@llvm/pr-subscribers-mlir-llvm @llvm/pr-subscribers-mlir Author: Ingo Müller (ingomueller-net) ChangesThis is another follow-up of #83004. Full diff: https://github.com/llvm/llvm-project/pull/83998.diff 2 Files Affected:
diff --git a/mlir/lib/Target/LLVM/NVVM/Target.cpp b/mlir/lib/Target/LLVM/NVVM/Target.cpp
index d5b6645631edd6..e31df99ea20d6f 100644
--- a/mlir/lib/Target/LLVM/NVVM/Target.cpp
+++ b/mlir/lib/Target/LLVM/NVVM/Target.cpp
@@ -22,6 +22,7 @@
#include "mlir/Target/LLVMIR/Dialect/NVVM/NVVMToLLVMIRTranslation.h"
#include "mlir/Target/LLVMIR/Export.h"
+#include "llvm/Config/llvm-config.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/FileUtilities.h"
#include "llvm/Support/FormatVariadic.h"
diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 8a8dd6e10c48aa..e917d310415f35 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -6182,6 +6182,7 @@ cc_library(
":config",
"//llvm:NVPTXCodeGen",
"//llvm:Support",
+ "//llvm:config",
],
)
|
ingomueller-net
force-pushed
the
llvm-config-dependency
branch
from
bb6858e
to
b724618
Compare
ingomueller-net
changed the title
ingomueller-net
force-pushed
the
llvm-config-dependency
branch
2 times, most recently
from
3923208
to
bb6858e
Compare
ingomueller-net
changed the title
|
Sorry for the noise. There are actually two unrelated changes to this file, one related to LLVM config (this PR) and one related to MLIR config (#84007) and I got confused by the two... |
joker-eph
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another follow-up of #83004.
NVVM/Target.cppuses the macroMLIR_NVPTXCOMPILER_ENABLED, which is defined inllvm-config.hbut did not include that file, yielding a warning when compiled with-Wundef. This PR adds the include.This is another follow-up of #83004, which made the same change forMLIR_CUDA_CONVERSIONS_ENABLED. As the previous PR, this PR commit exposes mentioned CMake variable throughmlir-config.hand uses the macro that is introduced with the same name. This replaces the macroMLIR_NVPTXCOMPILER_ENABLED, which the CMake files previously defined manually.