Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark] Delete WORKSPACE bzl files #84013

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

rupprecht
Copy link
Collaborator

As like 48d8684, WORKSPACE is another bazel-specific file that is unused. LLVM's bazel configuration is entirely in utils/bazel.

As like 48d8684, `WORKSPACE` is another bazel-specific file that is unused. LLVM's bazel configuration is entirely in `utils/bazel`.
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 5, 2024

@llvm/pr-subscribers-third-party-benchmark

Author: Jordan Rupprecht (rupprecht)

Changes

As like 48d8684, WORKSPACE is another bazel-specific file that is unused. LLVM's bazel configuration is entirely in utils/bazel.


Full diff: https://github.com/llvm/llvm-project/pull/84013.diff

2 Files Affected:

  • (removed) third-party/benchmark/WORKSPACE (-30)
  • (modified) third-party/update_benchmark.sh (+1)
diff --git a/third-party/benchmark/WORKSPACE b/third-party/benchmark/WORKSPACE
deleted file mode 100644
index 256207022597f5..00000000000000
--- a/third-party/benchmark/WORKSPACE
+++ /dev/null
@@ -1,30 +0,0 @@
-workspace(name = "com_github_google_benchmark")
-
-load("//:bazel/benchmark_deps.bzl", "benchmark_deps")
-
-benchmark_deps()
-
-load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies")
-
-rules_foreign_cc_dependencies()
-
-load("@rules_python//python:repositories.bzl", "py_repositories")
-
-py_repositories()
-
-load("@rules_python//python:pip.bzl", "pip_parse")
-
-pip_parse(
-    name = "tools_pip_deps",
-    requirements_lock = "//tools:requirements.txt",
-)
-
-load("@tools_pip_deps//:requirements.bzl", "install_deps")
-
-install_deps()
-
-new_local_repository(
-    name = "python_headers",
-    build_file = "@//bindings/python:python_headers.BUILD",
-    path = "<PYTHON_INCLUDE_PATH>",  # May be overwritten by setup.py.
-)
diff --git a/third-party/update_benchmark.sh b/third-party/update_benchmark.sh
index cda0bcfb1a7ac2..047efd945a86b5 100755
--- a/third-party/update_benchmark.sh
+++ b/third-party/update_benchmark.sh
@@ -13,4 +13,5 @@ git clone https://github.com/google/benchmark.git
 rm -rf benchmark/.git*
 find benchmark/ -name BUILD -delete
 find benchmark/ -name BUILD.bazel -delete
+find benchmark/ -name WORKSPACE -delete
 

@mtrofin
Copy link
Member

mtrofin commented Mar 5, 2024

LGTM, thanks for the fix!

@rupprecht rupprecht merged commit cc7544e into llvm:main Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants