Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flang][AArch64] Add support for complex16 params/returns #84217

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

kiranchandramohan
Copy link
Contributor

Fixes #84088

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir flang:codegen labels Mar 6, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 6, 2024

@llvm/pr-subscribers-flang-codegen

@llvm/pr-subscribers-flang-fir-hlfir

Author: Kiran Chandramohan (kiranchandramohan)

Changes

Fixes #84088


Full diff: https://github.com/llvm/llvm-project/pull/84217.diff

2 Files Affected:

  • (modified) flang/lib/Optimizer/CodeGen/Target.cpp (+4-2)
  • (added) flang/test/Fir/target-complex16.f90 (+29)
diff --git a/flang/lib/Optimizer/CodeGen/Target.cpp b/flang/lib/Optimizer/CodeGen/Target.cpp
index 7c77bdd79008f1..cea7a1f97f419f 100644
--- a/flang/lib/Optimizer/CodeGen/Target.cpp
+++ b/flang/lib/Optimizer/CodeGen/Target.cpp
@@ -737,7 +737,8 @@ struct TargetAArch64 : public GenericTarget<TargetAArch64> {
     CodeGenSpecifics::Marshalling marshal;
     const auto *sem = &floatToSemantics(kindMap, eleTy);
     if (sem == &llvm::APFloat::IEEEsingle() ||
-        sem == &llvm::APFloat::IEEEdouble()) {
+        sem == &llvm::APFloat::IEEEdouble() ||
+        sem == &llvm::APFloat::IEEEquad()) {
       // [2 x t]   array of 2 eleTy
       marshal.emplace_back(fir::SequenceType::get({2}, eleTy), AT{});
     } else {
@@ -751,7 +752,8 @@ struct TargetAArch64 : public GenericTarget<TargetAArch64> {
     CodeGenSpecifics::Marshalling marshal;
     const auto *sem = &floatToSemantics(kindMap, eleTy);
     if (sem == &llvm::APFloat::IEEEsingle() ||
-        sem == &llvm::APFloat::IEEEdouble()) {
+        sem == &llvm::APFloat::IEEEdouble() ||
+        sem == &llvm::APFloat::IEEEquad()) {
       // Use a type that will be translated into LLVM as:
       // { t, t }   struct of 2 eleTy
       marshal.emplace_back(mlir::TupleType::get(eleTy.getContext(),
diff --git a/flang/test/Fir/target-complex16.f90 b/flang/test/Fir/target-complex16.f90
new file mode 100644
index 00000000000000..9245b205f68a05
--- /dev/null
+++ b/flang/test/Fir/target-complex16.f90
@@ -0,0 +1,29 @@
+// RUN: tco --target=aarch64-unknown-linux-gnu %s | FileCheck %s --check-prefix=AARCH64
+
+// AARCH64-LABEL: define { fp128, fp128 } @gen16()
+func.func @gen16() -> !fir.complex<16> {
+  // AARCH64: %[[VAL1:.*]] = alloca { fp128, fp128 }, i64 1, align 16
+  %1 = fir.undefined !fir.complex<16>
+  %2 = arith.constant 1.0 : f128
+  %3 = arith.constant -4.0 : f128
+  %c0 = arith.constant 0 : i32
+  // AARCH64: store { fp128, fp128 } { fp128 0xL0000000000000000C001000000000000, fp128 0xL00000000000000003FFF000000000000 }, ptr %[[VAL1]], align 16
+  %4 = fir.insert_value %1, %3, [0 : index] : (!fir.complex<16>, f128) -> !fir.complex<16>
+  %c1 = arith.constant 1 : i32
+  %5 = fir.insert_value %4, %2, [1 : index] : (!fir.complex<16>, f128) -> !fir.complex<16>
+  // AARCH64: %[[VAL2:.*]] = load { fp128, fp128 }, ptr %[[VAL1]], align 16
+  // AARCH64: ret { fp128, fp128 } %[[VAL2]]
+  return %5 : !fir.complex<16>
+}
+
+// AARCH64: declare void @sink16([2 x fp128])
+func.func private @sink16(!fir.complex<16>) -> ()
+
+// AARCH64-LABEL: define void @call16()
+func.func @call16() {
+  // AARCH64: = call { fp128, fp128 } @gen16()
+  %1 = fir.call @gen16() : () -> !fir.complex<16>
+  // AARCH64: call void @sink16([2 x fp128] %
+  fir.call @sink16(%1) : (!fir.complex<16>) -> ()
+  return
+}

@kiranchandramohan
Copy link
Contributor Author

Godbolt link https://godbolt.org/z/1sMr4of7r

Copy link
Contributor

@vzakhari vzakhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing it, Kiran!

Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kiranchandramohan kiranchandramohan merged commit d742872 into llvm:main Mar 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:codegen flang:fir-hlfir flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flang] COMPLEX(16) parameters/returns are not supported for aarch64
4 participants