Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang] disable failing test #84300

Closed
wants to merge 1 commit into from
Closed

[flang] disable failing test #84300

wants to merge 1 commit into from

Conversation

ftynse
Copy link
Member

@ftynse ftynse commented Mar 7, 2024

This test has been failing on Windows for multiple consecutive days without any action taken. This prevents our CI from finding other problematic tests.

This test has been failing on Windows for multiple consecutive days
without any action taken. This prevents our CI from finding other
problematic tests.
@llvmbot llvmbot added the flang Flang issues not falling into any other category label Mar 7, 2024
@kiranchandramohan
Copy link
Contributor

@jeanPerier has a comment in the issue (#83534) that this was fixed by #83768.

@jeanPerier
Copy link
Contributor

@jeanPerier has a comment in the issue (#83534) that this was fixed by #83768.

That is right. @ftynse, it looks like your patch is based on an LLVM head that is week old and does not contain the fix.

I guess the pre-merge CI will fail for patch based on a head that predates the fix, sorry for that (The underlying issue in the code was very very old, more than two years old, but was exposed only recently, probably because the windows CI compiler version/conf changed and started optimized the code more, leading to a segfault).

Anyway, if you see failures on pre-merge CI on patches based on head including #83768, please feel free to reopen #83534 and revert #83822 (but it will not make any difference for patch based on heads without reverts).

@ftynse ftynse closed this Mar 7, 2024
@ftynse ftynse deleted the xfail-clang branch March 7, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants