Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOLT] Properly propagate Cursor errors #84378

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[BOLT] Properly propagate Cursor errors #84378

merged 1 commit into from
Mar 7, 2024

Conversation

maksfb
Copy link
Contributor

@maksfb maksfb commented Mar 7, 2024

Handle out-of-bounds reading errors correctly in LinuxKernelRewriter.

@maksfb
[BOLT] Properly propagate Cursor errors
28699fd 
Handle out-of-bounds reading errors correctly in LinuxKernelRewriter.
@maksfb maksfb added the BOLT label Mar 7, 2024
dcci
dcci approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fairly straightforward to me.

aaupov
aaupov reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General suggestion: you can set and propagate errors from DE, e.g. DE.getULEB128(&Offset, &Err)

@maksfb
Copy link
Contributor Author

maksfb commented Mar 7, 2024

General suggestion: you can set and propagate errors from DE, e.g. DE.getULEB128(&Offset, &Err)

Cursor interface is an alternative to passing Offset and Err to DE functions.

@maksfb maksfb merged commit a9b0d75 into llvm:main Mar 7, 2024
6 checks passed
@maksfb maksfb deleted the gh-cursor-error branch March 28, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaupov aaupov aaupov left review comments

@dcci dcci dcci approved these changes

@rafaelauler rafaelauler Awaiting requested review from rafaelauler rafaelauler is a code owner

@ayermolo ayermolo Awaiting requested review from ayermolo ayermolo is a code owner

Assignees
No one assigned
Labels
BOLT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maksfb @aaupov @dcci