Fix regular expression to guard against a repeating version string #84575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change d6c2cbbc651 causes the test
clang/test/utils/update_cc_test_checks/generated-funcs.test
to fail for compilers with version strings that repeat the sequence "version", such asclang version 19.0.0 (myvendor clang version 4.0.0)
.Making the expression preceding "\w+ version" non-greedy fix this.
Unfortunately there is no simple way to generate a test case, since it would require a change in the clang version string.