Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Exposes LLVM version number in the runtimes. #84641

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[cmake] Exposes LLVM version number in the runtimes. #84641

merged 1 commit into from
Mar 11, 2024

Conversation

mordante
Copy link
Member

@mordante mordante commented Mar 9, 2024

This allows sharing the LLVM version number in libc++.

@mordante
[cmake] Exposes LLVM version number in the runtimes.
7857ec9 
This allows sharing the LLVM version number in libc++.
@mordante mordante requested review from tru and tstellar March 9, 2024 17:01
@mordante mordante requested a review from a team as a code owner March 9, 2024 17:01
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Mar 9, 2024
@mordante
Copy link
Member Author

mordante commented Mar 9, 2024

I originally used this in #81362, there it's not needed anymore. However @ldionne and I feel it would be useful to have this. We probably can use this to set the libc++ version number.

@mordante mordante mentioned this pull request Mar 9, 2024
Merged
@mordante mordante merged commit 81e2047 into llvm:main Mar 11, 2024
50 of 52 checks passed
@mordante mordante deleted the review/expose_llvm_version_number_in_runtimes branch March 11, 2024 16:44
@firewave
Copy link

I wonder if this could help with #57263.

glandium added a commit to glandium/wasi-sdk that referenced this pull request Mar 12, 2024
@glandium
Support getting LLVM version from its new location
8964ff1 
llvm/llvm-project#84641 changed its location.
@glandium glandium mentioned this pull request Mar 12, 2024
Merged
abrown pushed a commit to WebAssembly/wasi-sdk that referenced this pull request Mar 12, 2024
@glandium
Support getting LLVM version from its new location (#399)
96bbd95 
llvm/llvm-project#84641 changed its location.
@mordante
Copy link
Member Author

I wonder if this could help with #57263.

These CMake values were already available to clang-tidy. This made them available for the run-times.

fifield added a commit to Xilinx/mlir-aie that referenced this pull request Apr 3, 2024
@fifield
Update llvm version location
7f81f2b 
Update for llvm/llvm-project#84641
@fifield fifield mentioned this pull request Apr 3, 2024
Merged
fifield added a commit to Xilinx/mlir-aie that referenced this pull request Apr 4, 2024
@fifield
Update llvm version location
a838e6b 
Update for llvm/llvm-project#84641
fifield added a commit to Xilinx/mlir-aie that referenced this pull request Apr 4, 2024
@fifield
Update llvm version location (#1165)
df42b66 
Update for llvm/llvm-project#84641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstellar tstellar tstellar approved these changes

@tru tru Awaiting requested review from tru

Assignees
No one assigned
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mordante @firewave @tstellar @llvmbot