[libc][stdbit] Fix truncation err in CPP bit_ceil #84683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @lntue as reviewer. |
|
@llvm/pr-subscribers-libc Author: Michael Flanders (Flandini) ChangesAfter #84657 was merged, buildbot is reporting two errors for libc-x86_64-debian-gcc-fullbuild-dbg. This PR fixes the truncation error when calling The errors are: Full diff: https://github.com/llvm/llvm-project/pull/84683.diff 1 Files Affected:
diff --git a/libc/src/__support/CPP/bit.h b/libc/src/__support/CPP/bit.h
index 4464703e4b064e..1a05728b850653 100644
--- a/libc/src/__support/CPP/bit.h
+++ b/libc/src/__support/CPP/bit.h
@@ -193,7 +193,7 @@ template <typename T>
bit_ceil(T value) {
if (value < 2)
return 1;
- return static_cast<T>(T(1) << cpp::bit_width<T>(value - 1u));
+ return static_cast<T>(T(1) << cpp::bit_width(value - 1U));
}
// Rotate algorithms make use of "Safe, Efficient, and Portable Rotate in C/C++"
|
lntue
approved these changes
Mar 10, 2024
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #84657 was merged, buildbot is reporting two errors for libc-x86_64-debian-gcc-fullbuild-dbg. This PR addresses the truncation error for
CPP::bit_ceil<unsigned char>andCPP::bit_ceil<unsigned short>.The errors are: