Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Add tablegen job pool support #84762

Merged
merged 2 commits into from Mar 12, 2024
Merged

[CMake] Add tablegen job pool support #84762

merged 2 commits into from Mar 12, 2024

Conversation

dstutt
Copy link
Collaborator

@dstutt dstutt commented Mar 11, 2024

Add the ability to set the number of tablegen jobs that can run in parallel
similar to the LLVM_PARALLEL_[COMPILE|LINK]_JOBS options that already exist.

@dstutt
[CMake] Add tablegen job pool support
8b99b81 
Add the ability to set the number of tablegen jobs that can run in parallel
similar to the LLVM_PARALLEL_[COMPILE|LINK]_JOBS options that already exist.
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Mar 11, 2024
nhaehnle
nhaehnle approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did run into the problem of builds aborting due to tablegen out of memory in the past, so this makes sense to me.

It looks reasonable to me, but I'm not a CMake expert, so perhaps give it a bit for somebody else to chime in.

compnerd
compnerd approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea to me. I wonder if we should generalise this to say CODEGEN but, I don't think that is worth nit-picking on currently.

@dstutt dstutt merged commit 9228859 into llvm:main Mar 12, 2024
5 checks passed
@dstutt dstutt deleted the llvm-tblgen-jobs branch March 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@nhaehnle nhaehnle nhaehnle approved these changes

@Paul-C-Anagnostopoulos Paul-C-Anagnostopoulos Awaiting requested review from Paul-C-Anagnostopoulos

@chandlerc chandlerc Awaiting requested review from chandlerc

Assignees
No one assigned
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dstutt @compnerd @nhaehnle @llvmbot