Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run pre-merge build with -k 0 placed after "${BUILD_DIR}" #84846

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

cpsughrue
Copy link
Contributor

#84828 added -k 0 to pre-merge CI so that if one job fails the others would continue building. This pull request fixes the location of -k 0 in the ninja command line.

Resolves #84842 and #83371

Copy link
Contributor

@jroelofs jroelofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cpsughrue cpsughrue merged commit a950c06 into llvm:main Mar 11, 2024
5 checks passed
@cpsughrue cpsughrue deleted the fix-ninja-build branch March 11, 2024 22:41
@cpsughrue cpsughrue changed the title Run pre-merge build with -k 0 placed after "${BUILD_DIR}" [CI] Run pre-merge build with -k 0 placed after "${BUILD_DIR}" Mar 11, 2024
@joker-eph
Copy link
Collaborator

Thanks for the fix @cpsughrue !

@cpsughrue
Copy link
Contributor Author

Thanks for the fix @cpsughrue !

No problem, thanks for the initial PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-commit CI's Linux x64 job is missing the argument to ninja -C
4 participants