[CodeGen][Tablegen] Fix uninitialized var and shift overflow. #84896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahesh-attarde
changed the title
phoebewang
reviewed
Mar 13, 2024
| @@ -935,7 +935,7 @@ void DecoderEmitter::emitTable(formatted_raw_ostream &OS, DecoderTable &Table, | |||
| unsigned Shift = 0; | |||
| do { | |||
| OS << ", " << (unsigned)*I; | |||
| Value += (*I & 0x7f) << Shift; | |||
| Value += ((uint64_t)(*I & 0x7f)) << Shift; | |||
There was a problem hiding this comment.
Not necessary. We can confirm (*I & 0x7f) is safe to do shift.
There was a problem hiding this comment.
Sorry, I think the (uint64_t) in needed, because Value is uint64_t and Shift may larger than 32.
There was a problem hiding this comment.
i see. there are no pending issues here, can you approve & merge request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix uninitialized var and shift overflow.