[sanitizer][windows] report symbols in clang_rt. or \compiler-rt\lib\ as internal.

[barcharcraz]

This is the windows equivalent to the existing filters.

Work from #81677 that can be applied separately (and is actually not critical for that PR)

[llvmbot]

@llvm/pr-subscribers-platform-windows

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Charlie Barto (barcharcraz)

Changes

This is the windows equivalent to the existing filters.

Work from #81677 that can be applied separately (and is actually not critical for that PR)

---

Full diff: https://github.com/llvm/llvm-project/pull/84971.diff

1 Files Affected:

• (modified) compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp (+4)

diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp
index f6b157c07c6557..ffbaf1468ec8ff 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp
@@ -39,8 +39,12 @@ static bool FrameIsInternal(const SymbolizedStack *frame) {
                internal_strstr(file, "/include/c++/") ||
                internal_strstr(file, "/include/g++")))
     return true;
+  if (file && internal_strstr(file, "\\compiler-rt\\lib\\"))
+    return true;
   if (module && (internal_strstr(module, "libclang_rt.")))
     return true;
+  if (module && (internal_strstr(module, "clang_rt.")))
+    return true;
   return false;
 }
 

[vitalybuka]

is libclang_rt. redundant then?

[barcharcraz]

I mean not if you happened to build the library with that name....

It might show up for cygwin or mingw builds. I don't see a reason to do platform specific preprocessing here.

[vitalybuka]

new if (module && (internal_strstr(module, "clang_rt."))) will match existing libclang

[vitalybuka]

It breaks this bot https://lab.llvm.org/buildbot/#/builders/127/builds/63297

[vitalybuka]

Ping

[barcharcraz]

Ping

thanks, looking now.

[barcharcraz]

fixed: #85137