Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm-ar] Be explicit about archive format in coff-symtab.test tests. #85112

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

cjacek
Copy link
Contributor

@cjacek cjacek commented Mar 13, 2024

Fixes test failures on AIX after #82898.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 13, 2024

@llvm/pr-subscribers-llvm-binary-utilities

Author: Jacek Caban (cjacek)

Changes

Fixes test failures on AIX after #82898.


Full diff: https://github.com/llvm/llvm-project/pull/85112.diff

1 Files Affected:

  • (modified) llvm/test/tools/llvm-ar/coff-symtab.test (+1-1)
diff --git a/llvm/test/tools/llvm-ar/coff-symtab.test b/llvm/test/tools/llvm-ar/coff-symtab.test
index 4f7270d9e2c6e7..4a574723a9bea8 100644
--- a/llvm/test/tools/llvm-ar/coff-symtab.test
+++ b/llvm/test/tools/llvm-ar/coff-symtab.test
@@ -16,7 +16,7 @@ RUN: llvm-nm --print-armap out3.a | FileCheck %s
 
 Create an empty archive with no symbol map, add a COFF file to it and check that the output archive is a COFF archive.
 
-RUN: llvm-ar rcS out4.a
+RUN: llvm-ar --format coff rcS out4.a
 RUN: llvm-ar rs out4.a coff-symtab.obj
 RUN: llvm-nm --print-armap out4.a | FileCheck %s
 

@cjacek cjacek merged commit c419661 into llvm:main Mar 13, 2024
5 of 6 checks passed
@cjacek cjacek deleted the ar-coff-symtab branch March 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants