Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add a section on CI to the GitHub documentation #85376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Doc] Add a section on CI to the GitHub documentation #85376

wants to merge 1 commit into from

Conversation

joker-eph
Copy link
Collaborator

@joker-eph joker-eph commented Mar 15, 2024 •
edited

nikic
nikic reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds pretty reasonable to me.

llvm/docs/Contributing.rst Outdated Show resolved Hide resolved
llvm/docs/Contributing.rst Outdated Show resolved Hide resolved
llvm/docs/Contributing.rst Outdated Show resolved Hide resolved
llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
rengolin
rengolin reviewed Mar 15, 2024
View reviewed changes
llvm/docs/Contributing.rst Outdated Show resolved Hide resolved
llvm/docs/GitHub.rst Show resolved Hide resolved
@joker-eph joker-eph requested a review from rengolin March 18, 2024 17:32
nikic
nikic approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

llvm/docs/Contributing.rst Outdated Show resolved Hide resolved
llvm/docs/Contributing.rst Outdated Show resolved Hide resolved
llvm/docs/Contributing.rst Outdated Show resolved Hide resolved
llvm/docs/GitHub.rst Outdated Show resolved Hide resolved
banach-space
banach-space approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joker-eph
Copy link
Collaborator Author

@tstellar @preames : any more comment here?

tstellar
tstellar approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@tstellar tstellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstellar tstellar tstellar approved these changes

@nikic nikic nikic approved these changes

@rengolin rengolin rengolin approved these changes

@banach-space banach-space banach-space approved these changes

@preames preames Awaiting requested review from preames

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joker-eph @tstellar @nikic @rengolin @banach-space