[OpenMP] Add num_threads clause list format and strict modifier support #85466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to the runtime for 6.0 spec features that allow num_threads clause to take a list, and also make use of the strict modifier. Provides new compiler interface functions for these features.
|
Can we have tests? |
shiltian
changed the title
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
shiltian
approved these changes
Mar 30, 2024
| @@ -1268,6 +1268,11 @@ kmp_set_disp_num_buffers 890 | |||
| __kmpc_atomic_val_8_cas_cpt 2158 | |||
| %endif | |||
|
|
|||
| # No longer need to put ordinal numbers | |||
There was a problem hiding this comment.
This will not cause issue on Windows anymore?
There was a problem hiding this comment.
Right, you can add exported symbols just by name now. Older symbols keep their ordinal number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to the runtime for 6.0 spec features that allow num_threads clause to take a list, and also make use of the strict modifier. Provides new compiler interface functions for these features.