[openmp] using h/w clock tick to measure time instead of gettimeofday… #85474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad0
reviewed
Mar 16, 2024
brad0
reviewed
Mar 16, 2024
devnexen
force-pushed
the
omp_arm64_upd
branch
2 times, most recently
from
e2932d2
to
5895bea
Compare
|
Out of curiosity, where was this tested? and why was it disabled on macOS? |
|
I ll be giving another round of tests on Linux after last changes. on macOs two tests no longer passed. |
What were the tests? details? |
|
one of them was omp_lock so directly related to the changes. anyhow putting it back to draft for now. |
devnexen
force-pushed
the
omp_arm64_upd
branch
2 times, most recently
from
c4b7c57
to
afd4d05
Compare
|
✅ With the latest revision this PR passed the Python code formatter. |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
… on Linux/arm64. using counter timer frequency register for that purpose, available in user mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… on Linux/arm64.
using counter timer frequency register for that purpose, available in user mode.