Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT][DWARF] Add support to debug_names for DW_AT_abstract_origin/DW_AT_specification #85485

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

ayermolo
Copy link
Contributor

@ayermolo ayermolo commented Mar 15, 2024

According to the DWARF spec a DIE that has DW_AT_specification or
DW_AT_abstract_origin can be part of .debug_name if a DIE those
attribute points to has DW_AT_name or DW_AT_linkage_name.

@ayermolo ayermolo added the BOLT label Mar 15, 2024
@ayermolo ayermolo changed the title Debug names spec abstract origin [BOLT][DWARF] Add support to debug_names for DW_AT_abstract_origin/DW_AT_specification Mar 16, 2024
DW_AT_abstract_origin/DW_AT_specification

According to the DWARF spec a DIE that has DW_AT_specification or
DW_AT_abstract_origin can be part of .debug_name if a DIE those
attribute points to has DW_AT_name or DW_AT_linkage_name.
@ayermolo ayermolo force-pushed the debugNamesSpecAbstractOrigin branch from 7b3b001 to 6e73ff8 Compare March 16, 2024 15:17
Copy link
Contributor

@maksfb maksfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ayermolo ayermolo merged commit 4841858 into llvm:main Mar 18, 2024
4 checks passed
@ayermolo ayermolo deleted the debugNamesSpecAbstractOrigin branch March 18, 2024 22:28
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
…_AT_specification (llvm#85485)

According to the DWARF spec a DIE that has DW_AT_specification or
DW_AT_abstract_origin can be part of .debug_name if a DIE those
attribute points to has DW_AT_name or DW_AT_linkage_name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants