Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mips][NFC] Garbage collect unused code #85499

Merged
merged 1 commit into from
Mar 16, 2024
Merged

[Mips][NFC] Garbage collect unused code #85499

merged 1 commit into from
Mar 16, 2024

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Mar 16, 2024

No description provided.

@brad0 brad0 requested a review from wzssyqa March 16, 2024 07:00
@wzssyqa
Copy link
Contributor

wzssyqa commented Mar 16, 2024

Go ahead please.
I left these lines as I thought that they will be useful if we'd like to support -mabicalls -mno-shared in future.

@brad0
Copy link
Contributor Author

brad0 commented Mar 16, 2024

Go ahead please. I left these lines as I thought that they will be useful if we'd like to support -mabicalls -mno-shared in future.

It's not that I would try to dissuade you from adding support if desirable. It's just as MaskRay said usually code is not left in like that. You can always re-add it as necessary.

@brad0 brad0 merged commit a02b79f into llvm:main Mar 16, 2024
4 of 5 checks passed
@brad0 brad0 deleted the mips_clean branch March 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants