[OpenMP] Sync the team task for serialized parallel #85600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test? |
shiltian
changed the title
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
shiltian
reviewed
Mar 18, 2024
| @@ -0,0 +1,33 @@ | |||
| // RUN: %libomp-compile-and-run | |||
| // RUN: %libomp-cxx-compile && env OMP_NUM_THREADS=1 %libomp-run | |||
There was a problem hiding this comment.
Why does the C version not need the env while the C++ version need?
| # pragma omp barrier | ||
| } | ||
| return 0; | ||
| } |
|
As Andrey suggested in the other issue, we should remove the "optimization" for serial teams. If this change fixes the different issues, I'm fine with keeping the serial teams. |
|
Looks like #86859 will fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix #81488