Convert copy to r-value reference. #85606
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That seems to be the intention based on calling code.
|
@aeubanks please comment if I understood the intention correctly. Did you instead intend to have a copy constructor? |
|
ah this is probably right (need the same thing in |
|
@phoebewang The original author seems to have referred code in a different file which has the same issue. I can create a separate PR for that. |
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
That seems to be the intention based on calling code.
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
May 15, 2024
…aa52a9799 Local branch amd-gfx f11aa52 Merged main:e04dd68a3a26d3ebdc2db07cf2f8807a02d30ce2 into amd-gfx:26b5e3593208 Remote branch main ff60a84 Convert copy to r-value reference. (llvm#85606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That seems to be the intention based on calling code.