[RemoveDIs] Add flag to control loading into new debug mode from bitcode #85649
Conversation
--load-bitcode-into-experimental-debuginfo-iterators false: Convert to the old debug mode after reading. true: Upgrade to the new debug info format (*). unset: Same as false (for now). (*) As of this patch it actually just means "don't convert to either mode after loading". Auto-upgrading will be implemented in an upcoming patch. With this flag we can incrementally add support for RemoveDIs by overriding the "unset" behaviour in individual tools.
| /// support for the RemoveDIs format. | ||
| cl::opt<cl::boolOrDefault> LoadBitcodeIntoNewDbgInforFormat( | ||
| "load-bitcode-into-experimental-debuginfo-iterators", cl::Hidden); | ||
|
|
There was a problem hiding this comment.
May be to keep consistency with the previous options, include cl::desc.
|
Thanks @CarlosAlbertoEnciso - To answer your two inline questions about the Which effectively means for that tool only, the default is changed from false to true. It's useful to be able to give each tool control over this while we're implementing support, so it can be done incrementally. Eventually the flag will be removed. |
Thanks for the clarification on |
|
Thanks both for the review |
…ode (llvm#85649) --load-bitcode-into-experimental-debuginfo-iterators false: Convert to the old debug mode after reading. true: Upgrade to the new debug info format (*). unset: Same as false (for now). (*) As of this patch it actually just means "don't convert to either mode after loading". Auto-upgrading will be implemented in an upcoming patch. With this flag we can incrementally add support for RemoveDIs by overriding the "unset" behaviour in individual tools. The flag can be removed once all tools support the new debug info mode. Change-Id: I81f7fb83ac95223497d5577354bff7a76b2edb3e
…ode (llvm#85649) --load-bitcode-into-experimental-debuginfo-iterators false: Convert to the old debug mode after reading. true: Upgrade to the new debug info format (*). unset: Same as false (for now). (*) As of this patch it actually just means "don't convert to either mode after loading". Auto-upgrading will be implemented in an upcoming patch. With this flag we can incrementally add support for RemoveDIs by overriding the "unset" behaviour in individual tools. The flag can be removed once all tools support the new debug info mode.
(*) As of this patch it actually just means "don't convert to either mode after loading". Auto-upgrading will be implemented in an upcoming patch.
With this flag we can incrementally add support for RemoveDIs by overriding the "unset" behaviour in individual tools. The flag can be removed once all tools support the new debug info mode.