[OpenMP] Fix ompx_dump_mapping_tables lit test #85753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an API call ompx_dump_mapping_tables. This allows users to debug the mapping tables and can be especially useful for unified shared memory applications to check if the code behaves in the way it should. The implementation reuses code already present to dump mapping tables (in a debug setting).
Add void to parameter list. Co-authored-by: Joseph Huber <huberjn@outlook.com>
Co-authored-by: Joseph Huber <huberjn@outlook.com>
Fixes ompx_dump_mapping_tables test by only using one device after breaking built bots.
llvmbot
added
openmp:libomp
You can test this locally with the following command:git-clang-format --diff 703920d4138d02bde4f4bf70ba809b63bef25c37 ed507006215559655507af62fdd80f6766b75d70 -- openmp/libomptarget/test/api/ompx_dump_mapping_tables.cppView the diff from clang-format here.diff --git a/openmp/libomptarget/test/api/ompx_dump_mapping_tables.cpp b/openmp/libomptarget/test/api/ompx_dump_mapping_tables.cpp
index 6b05cea73d..d928820462 100644
--- a/openmp/libomptarget/test/api/ompx_dump_mapping_tables.cpp
+++ b/openmp/libomptarget/test/api/ompx_dump_mapping_tables.cpp
@@ -9,7 +9,6 @@ int main() {
int *a = new __int32_t[N]; // mapped and released from device 0
int *b = new __int32_t[2 * N]; // mapped to device 0
-
// clang-format off
// CHECK: Mapping tables after target enter data:
// CHECK-NEXT: omptarget device 0 info: OpenMP Host-Device pointer mappings after block
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ompx_dump_mapping_tables test by only using one device after breaking built bots