[libc][bazel] fix missing iterator inclusion #85840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch llvm#85702 added a new iterator header for array to use, but didn't add it as a dependency in the bazel build. This patch fixes the issue.
|
@llvm/pr-subscribers-libc Author: Michael Jones (michaelrj-google) ChangesPatch #85702 added a new iterator header for array to use, but didn't Full diff: https://github.com/llvm/llvm-project/pull/85840.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 77fb8c16507ba1..4766e168daadbd 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -161,10 +161,20 @@ libc_support_library(
],
)
+libc_support_library(
+ name = "__support_cpp_iterator",
+ hdrs = ["src/__support/CPP/iterator.h"],
+ deps = [
+ ":__support_cpp_type_traits",
+ ":__support_macros_attributes",
+ ],
+)
+
libc_support_library(
name = "__support_cpp_array",
hdrs = ["src/__support/CPP/array.h"],
deps = [
+ ":__support_cpp_iterator",
":__support_macros_attributes",
],
)
|
lntue
approved these changes
Mar 19, 2024
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
Patch llvm#85702 added a new iterator header for array to use, but didn't add it as a dependency in the bazel build. This patch fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch #85702 added a new iterator header for array to use, but didn't
add it as a dependency in the bazel build. This patch fixes the issue.