-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TableGen] Introduce a less aggressive suppression for HwMode Decoder… #86060
[TableGen] Introduce a less aggressive suppression for HwMode Decoder… #86060
Conversation
superZWT123
commented
Mar 21, 2024
•
edited
edited
- Remove 'AllModes' and 'DefaultMode' suffixes for DecoderTables under default HwMode.
- Introduce a less aggressive suppression for HwMode DecoderTable, only reduce necessary tables duplications. This allows encodings under different HwModes to retain the original DecoderNamespace.
- Change 'suppress-per-hwmode-duplicates' command option from bool type to enum type, allowing users to choose what level of suppression to use.
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
✅ With the latest revision this PR passed the C/C++ code formatter. |
478b4e1
to
cc5470e
Compare
Hi kparzysz, nvjle ,following the discussion on the previous pull request pre-pull-request, I have changed the type of ‘suppress-per-hwmode-duplicates’ from 'bool' to 'enum', allowing users to choose the degree of table suppression they prefer. Could you please take another look at it and provide your review comments ? Thanks a lot! |
cc5470e
to
b2a9206
Compare
Hi @superZWT123, |
Thank you, nvjle . |
Hi @nvjle , I hope this message finds you well. I want to kindly remind you about the pending review of the code we discussed. The completion of this part is crucial as the remaining fixing for 'EncodingByHwMode' are dependent on it. I understand and appreciate the time and effort it takes to review code, and I hope we can expedite this process to keep the project moving forward smoothly. |
Hi, @topperc, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @topperc , could you please help me merge this PR into the main branch? I’m not a committer and don’t have write access to this repository. Thank you very much! |
9334cc3
to
fd93753
Compare
…Table 1. Remove 'AllModes' and 'DefaultMode' suffixes for DecoderTables under default HwMode. 2. Introduce a less aggressive suppression for HwMode DecoderTable, only reduce necessary tables duplications. This allows encodings under different HwModes to retain the original DecoderNamespace. 3. Change 'suppress-per-hwmode-duplicates' command option from bool type to enum type, allowing users to choose what level of suppression to use.
Use std::set to collect HwModes for DecoderNamespace, simplifying code logic.
fd93753
to
a2fee80
Compare
@superZWT123 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |