Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[github] Add ClangIR to new-prs-labeler.yml #86088

Merged
merged 2 commits into from
Apr 17, 2024
Merged

[github] Add ClangIR to new-prs-labeler.yml #86088

merged 2 commits into from
Apr 17, 2024

Conversation

lanza
Copy link
Member

@lanza lanza commented Mar 21, 2024

No description provided.

@boomanaiden154
Copy link
Contributor

Make sure that the ClangIR team is created first before landing this so that everything works as expected.

@lanza
Copy link
Member Author

lanza commented Apr 17, 2024

Make sure that the ClangIR team is created first before landing this so that everything works as expected.

What do you mean here by "ClangIR team is created"?

@lanza lanza added the ClangIR Anything related to the ClangIR project label Apr 17, 2024
@cor3ntin cor3ntin requested a review from tru April 17, 2024 07:19
cor3ntin
cor3ntin reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No needs for team to label PRs.
However, there needs to be a team for notifications to work.
Maybe Tom/Tobias can help with teams creation.

The name of the label/team must match and it needs to be all lowercase afaik.

@tstellar
Copy link
Collaborator

No needs for team to label PRs. However, there needs to be a team for notifications to work. Maybe Tom/Tobias can help with teams creation.

The name of the label/team must match and it needs to be all lowercase afaik.

Uppercase labels are OK. I've added the team now.

@lanza lanza merged commit ed741ff into main Apr 17, 2024
4 checks passed
@lanza lanza deleted the users/lanza/patch1 branch April 17, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cor3ntin cor3ntin cor3ntin left review comments

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@tstellar tstellar Awaiting requested review from tstellar

@tru tru Awaiting requested review from tru

Assignees
No one assigned
Labels
ClangIR Anything related to the ClangIR project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lanza @boomanaiden154 @tstellar @cor3ntin @bcardosolopes