Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][bazel] Fix bazel build #86190

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

gchatelet
Copy link
Contributor

Follow up on #86140

@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Mar 21, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 21, 2024

@llvm/pr-subscribers-libc

Author: Guillaume Chatelet (gchatelet)

Changes

Follow up on #86140


Full diff: https://github.com/llvm/llvm-project/pull/86190.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/BUILD.bazel (+6)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 2e8d475f196eff..0d531a3dc12a7c 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -97,6 +97,11 @@ libc_support_library(
     deps = [":llvm_libc_macros_float_macros"],
 )
 
+libc_support_library(
+    name = "llvm_libc_macros_fcntl_macros",
+    hdrs = ["include/llvm-libc-macros/linux/fcntl-macros.h"],
+)
+
 ############################### Support libraries ##############################
 
 libc_support_library(
@@ -3271,6 +3276,7 @@ libc_function(
         ":__support_common",
         ":__support_osutil_syscall",
         ":errno",
+        ":llvm_libc_macros_fcntl_macros",
     ],
 )
 

@gchatelet
Copy link
Contributor Author

@nickdesaulniers @rupprecht feel free to submit this on my behalf as I'll be AFK soonish.

@nickdesaulniers
Copy link
Member

@michaelrj-google thoughts on globing here? (As in, should we be employing globing such that we don't have to keep adding these)?

@nickdesaulniers nickdesaulniers merged commit 70a9c52 into llvm:main Mar 21, 2024
7 checks passed
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants